Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] New melcor interface #1997

Closed
wants to merge 12 commits into from
Closed

Conversation

mattdon
Copy link

@mattdon mattdon commented Oct 18, 2022


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

The MELCOR interface has been merged into a single python module. The finalize_code_output uses an external git code developed at the Sapienza University of Rome to directly extract output variables from the MELCOR PLT file.

What are the significant changes in functionality due to this change request?

Users can use this new code interface that can output MELCOR variables associated with different packages (CVH, FL, COR, RN, ESF, etc.). Users should add an XML node to the RAVEN input deck listing all the variables to be used as output.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@wangcj05
Copy link
Collaborator

@mattdon The Precheck failed:

Run the "delete_trailing_whitespace.sh" script in your raven/developer_tools/ directory.

ERROR: RAVEN prefers two spaces instead of tabs. The following files contain tab characters:
ravenframework/CodeInterfaceClasses/MELCOR/melcorCombinedInterface.py

@moosebuild
Copy link

Job Test qsubs sawtooth on 446f280 : canceled by @wangcj05

no need to test

@wangcj05
Copy link
Collaborator

wangcj05 commented Nov 2, 2022

@mattdon FYI, The melcor test failed:
image

@wangcj05
Copy link
Collaborator

wangcj05 commented Nov 2, 2022

The test is:
image

@mattdon
Copy link
Author

mattdon commented Nov 2, 2022

@mattdon FYI, The melcor test failed: image

To make it run, some additional nodes must be added to the RAVEN XML input.

ex

@wangcj05
Copy link
Collaborator

wangcj05 commented Nov 2, 2022

@mattdon Could you able to update the test to reflect your suggestions?

@moosebuild
Copy link

Job Mingw Test on 6deb3ab : canceled by @joshua-cogliati-inl

will fail due to conda issue.

@wangcj05 wangcj05 added the RAVENv2.3 for RAVEN 2.3 Release label Nov 16, 2022
@mandd mandd changed the title New melcor interface [WIP] New melcor interface Nov 17, 2022
@wangcj05 wangcj05 removed the RAVENv2.3 for RAVEN 2.3 Release label May 19, 2023
@wangcj05
Copy link
Collaborator

wangcj05 commented Jun 7, 2023

This is a duplicated PR for #2017. I will close it.

@wangcj05 wangcj05 closed this Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants