[WIP]: Enabling min max list #2100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e iteration is completed.
…tests. Most of conflicts are resolved.
…enablingMinMaxList
|
Job Precheck on ccde4d9 : invalidated by @Jimmy-INL |
1 similar comment
|
Job Precheck on ccde4d9 : invalidated by @Jimmy-INL |
|
Job Precheck on c3688e2 : invalidated by @Jimmy-INL |
wangcj05
reviewed
Apr 6, 2023
plugins/TEAL
Outdated
Comment on lines
+76
to
+77
| self.constraints = None | ||
| self.constraintsV = None |
There was a problem hiding this comment.
provide comments for this variables
Comment on lines
+84
to
+89
| self.multiBestPoint = None | ||
| self.multiBestFitness = None | ||
| self.multiBestObjective = None | ||
| self.multiBestConstraint = None | ||
| self.multiBestRank = None | ||
| self.multiBestCD = None |
There was a problem hiding this comment.
I would suggest to add comments for all self variables in the init method.
|
|
||
| self._collectOptPoint(rlz, offSpringFitness, objectiveVal,g) | ||
| self._resolveNewGeneration(traj, rlz, objectiveVal, offSpringFitness, g, info) | ||
| if not self._canHandleMultiObjective or len(self._objectiveVar) == 1: # This is a single-objective Optimization case |
There was a problem hiding this comment.
I think self._canHandleMultiObjective is alway True for GA, so I think you do not need to included it in the check
| for y in (self._constraintFunctions + self._impConstraintFunctions): | ||
| params += y.parameterNames() | ||
| for p in list(set(params) -set([self._objectiveVar[0]]) -set(list(self.toBeSampled.keys()))): | ||
| # for p in list(set(params) -set([self._objectiveVar]) -set(list(self.toBeSampled.keys()))): |
| sortedConst,sortedRank,sortedCD,sortedAge,sortedPopulation,sortedObjectives,sortedConstV = \ | ||
| zip(*[(x,y,z,i,j,k,a) for x,y,z,i,j,k,a in \ | ||
| sorted(zip(newConstMerged,newPopRank.data,newPopCD.data,newAge,newPopulationMerged.tolist(),newObjectivesMerged_pair,newConstVMerged),reverse=False,key=lambda x: (x[0], x[1], -x[2]))]) | ||
| sortedConstT,sortedRankT,sortedCDT,sortedAgeT,sortedPopulationT,sortedObjectivesT,sortedConstVT = \ |
There was a problem hiding this comment.
I would suggest to separate the assignments here
Comment on lines
+83
to
+88
| ## tentative code block start | ||
| # import matplotlib.pyplot as plt | ||
| # from mpl_toolkits.mplot3d import Axes3D | ||
| # xdata = [item[0] for item in data] | ||
| # ydata = [item[1] for item in data] | ||
| # zdata = [item[2] for item in data] |
Comment on lines
+106
to
+111
| # ax3d = plt.figure().gca(projection='3d') | ||
| # ax3d.scatter(xdata, ydata, zdata) | ||
| # for x, y, z, label in zip(xdata, ydata, zdata, nonDominatedRank): | ||
| # ax3d.text(x, y, z, label) | ||
| # plt.title("Data") | ||
| # plt.show() |
Comment on lines
+122
to
+127
| # # tentative code block start | ||
| # import matplotlib.pyplot as plt | ||
| # from mpl_toolkits.mplot3d import Axes3D | ||
| # xdata = [item[0] for item in objectives] | ||
| # ydata = [item[1] for item in objectives] | ||
| # zdata = [item[2] for item in objectives] |
Comment on lines
+143
to
+148
| # ax3d = plt.figure().gca(projection='3d') | ||
| # ax3d.scatter(xdata, ydata, zdata) | ||
| # for x, y, z, label in zip(xdata, ydata, zdata, [i+j for i, j in zip([str(ele) for ele in rank.data.tolist()], [str(ele) for ele in crowdDist.tolist()])]): | ||
| # ax3d.text(x, y, z, label) | ||
| # plt.title("Data") | ||
| # plt.show() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
What are the significant changes in functionality due to this change request?
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>to True.raven/tests/framework/user_guideandraven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.