-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]: Enabling min max list #2100
base: devel
Are you sure you want to change the base?
Conversation
…e iteration is completed.
…tests. Most of conflicts are resolved.
…enablingMinMaxList
Job Precheck on ccde4d9 : invalidated by @Jimmy-INL |
1 similar comment
Job Precheck on ccde4d9 : invalidated by @Jimmy-INL |
Job Precheck on c3688e2 : invalidated by @Jimmy-INL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some general comments.
plugins/TEAL
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this update
self.constraints = None | ||
self.constraintsV = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
provide comments for this variables
self.multiBestPoint = None | ||
self.multiBestFitness = None | ||
self.multiBestObjective = None | ||
self.multiBestConstraint = None | ||
self.multiBestRank = None | ||
self.multiBestCD = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to add comments for all self variables in the init method.
|
||
self._collectOptPoint(rlz, offSpringFitness, objectiveVal,g) | ||
self._resolveNewGeneration(traj, rlz, objectiveVal, offSpringFitness, g, info) | ||
if not self._canHandleMultiObjective or len(self._objectiveVar) == 1: # This is a single-objective Optimization case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think self._canHandleMultiObjective is alway True for GA, so I think you do not need to included it in the check
for y in (self._constraintFunctions + self._impConstraintFunctions): | ||
params += y.parameterNames() | ||
for p in list(set(params) -set([self._objectiveVar[0]]) -set(list(self.toBeSampled.keys()))): | ||
# for p in list(set(params) -set([self._objectiveVar]) -set(list(self.toBeSampled.keys()))): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove?
sortedConst,sortedRank,sortedCD,sortedAge,sortedPopulation,sortedObjectives,sortedConstV = \ | ||
zip(*[(x,y,z,i,j,k,a) for x,y,z,i,j,k,a in \ | ||
sorted(zip(newConstMerged,newPopRank.data,newPopCD.data,newAge,newPopulationMerged.tolist(),newObjectivesMerged_pair,newConstVMerged),reverse=False,key=lambda x: (x[0], x[1], -x[2]))]) | ||
sortedConstT,sortedRankT,sortedCDT,sortedAgeT,sortedPopulationT,sortedObjectivesT,sortedConstVT = \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to separate the assignments here
## tentative code block start | ||
# import matplotlib.pyplot as plt | ||
# from mpl_toolkits.mplot3d import Axes3D | ||
# xdata = [item[0] for item in data] | ||
# ydata = [item[1] for item in data] | ||
# zdata = [item[2] for item in data] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove?
# ax3d = plt.figure().gca(projection='3d') | ||
# ax3d.scatter(xdata, ydata, zdata) | ||
# for x, y, z, label in zip(xdata, ydata, zdata, nonDominatedRank): | ||
# ax3d.text(x, y, z, label) | ||
# plt.title("Data") | ||
# plt.show() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove?
# # tentative code block start | ||
# import matplotlib.pyplot as plt | ||
# from mpl_toolkits.mplot3d import Axes3D | ||
# xdata = [item[0] for item in objectives] | ||
# ydata = [item[1] for item in objectives] | ||
# zdata = [item[2] for item in objectives] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove?
# ax3d = plt.figure().gca(projection='3d') | ||
# ax3d.scatter(xdata, ydata, zdata) | ||
# for x, y, z, label in zip(xdata, ydata, zdata, [i+j for i, j in zip([str(ele) for ele in rank.data.tolist()], [str(ele) for ele in crowdDist.tolist()])]): | ||
# ax3d.text(x, y, z, label) | ||
# plt.title("Data") | ||
# plt.show() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove?
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
What are the significant changes in functionality due to this change request?
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>
to True.raven/tests/framework/user_guide
andraven/docs/workshop
) have been changed, the associated documentation must be reviewed and assured the text matches the example.