Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of pip installation of repo via pip. Closes #2276 #2277

Merged

Conversation

alfoa
Copy link
Collaborator

@alfoa alfoa commented Mar 6, 2024


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Closes #2276

What are the significant changes in functionality due to this change request?

Addition of the possibility in the library_hadler to accept a keyword "repo" to indicate that a dependency should be installed from a GitHub repository directly (using pip install git+https)


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

scripts/library_handler.py Outdated Show resolved Hide resolved
…s' of github.com:idaholab/raven into aalfonsi/supportInstallationFromRepositoryIndependencies
@moosebuild
Copy link

Job Test CentOS 8 on e9e6f83 : invalidated by @wangcj05

envs issue

@joshua-cogliati-inl
Copy link
Contributor

Hm, can you give an example of how this would be used (sample dependencies.xml?) Thanks.

@moosebuild
Copy link

Job Test qsubs sawtooth on e9e6f83 : invalidated by @alfoa

@moosebuild
Copy link

Job Test CentOS 8 on e9e6f83 : invalidated by @alfoa

@alfoa
Copy link
Collaborator Author

alfoa commented Mar 7, 2024

Hm, can you give an example of how this would be used (sample dependencies.xml?) Thanks.

Absolutely.
Here it as an example:

<dependencies>
  <main>
    <networkx/>
    <pytest/>
    <pyomo source='forge'/>
    <glpk source='forge' skip_check='True'/>
    <shapely source="pip"/>
    <armi source="pip"  repo="https://github.com/terrapower/armi.git"/>
  </main>

</dependencies>

wangcj05
wangcj05 previously approved these changes Mar 7, 2024
Copy link
Collaborator

@wangcj05 wangcj05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfoa This PR looks good to me. One suggestion is to put an example in our dependency file (using commented lines), since we do not have documentation for library handling.

@joshua-cogliati-inl Do you have any comments on this PR?

@alfoa
Copy link
Collaborator Author

alfoa commented Mar 7, 2024

@alfoa This PR looks good to me. One suggestion is to put an example in our dependency file (using commented lines), since we do not have documentation for library handling.

@joshua-cogliati-inl Do you have any comments on this PR?

Perfect. Added

@alfoa alfoa requested a review from wangcj05 March 8, 2024 18:21
Copy link
Collaborator

@wangcj05 wangcj05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are good.

@wangcj05
Copy link
Collaborator

PR checklist is good. PR can be merged.

@wangcj05 wangcj05 merged commit a62eb3f into devel Mar 11, 2024
12 checks passed
@wangcj05 wangcj05 deleted the aalfonsi/supportInstallationFromRepositoryIndependencies branch March 11, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Support of installation of a dependency via GitHub repo
4 participants