-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of pip installation of repo via pip. Closes #2276 #2277
Support of pip installation of repo via pip. Closes #2276 #2277
Conversation
…s' of github.com:idaholab/raven into aalfonsi/supportInstallationFromRepositoryIndependencies
Job Test CentOS 8 on e9e6f83 : invalidated by @wangcj05 envs issue |
Hm, can you give an example of how this would be used (sample dependencies.xml?) Thanks. |
Job Test qsubs sawtooth on e9e6f83 : invalidated by @alfoa |
Job Test CentOS 8 on e9e6f83 : invalidated by @alfoa |
… 2..so f-stringed cannot be used
Absolutely.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alfoa This PR looks good to me. One suggestion is to put an example in our dependency file (using commented lines), since we do not have documentation for library handling.
@joshua-cogliati-inl Do you have any comments on this PR?
Perfect. Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes are good.
PR checklist is good. PR can be merged. |
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Closes #2276
What are the significant changes in functionality due to this change request?
Addition of the possibility in the library_hadler to accept a keyword "repo" to indicate that a dependency should be installed from a GitHub repository directly (using
pip install git+https
)For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>
to True.raven/tests/framework/user_guide
andraven/docs/workshop
) have been changed, the associated documentation must be reviewed and assured the text matches the example.