Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defect fix of SimulatedAnnealing with 1 variable optimization #2296

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

alfoa
Copy link
Collaborator

@alfoa alfoa commented Apr 11, 2024


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Closes #2295

What are the significant changes in functionality due to this change request?

The SimulatedAnnealing could not process 1-variable optimization problem (crash). This PR addresses the problem
maxing sure that ``delta'' variable is always indexable (np array).

A test is added to show that 1 variable optimizations are now possible

In addition, a typo in the Serpent interface is corrected as well (no wrong results to the users but just a crash in case of usage of ``include'' paths sampled by RAVEN.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@alfoa alfoa added defect devel issues in current devel labels Apr 11, 2024
@moosebuild
Copy link

Job Mingw Test on fb16367 : invalidated by @alfoa

fetch failed

@alfoa alfoa requested review from mandd and wangcj05 April 12, 2024 16:05
@alfoa
Copy link
Collaborator Author

alfoa commented Apr 12, 2024

@wangcj05 @mandd ready to review.
Thanks in advance.

Copy link
Collaborator

@wangcj05 wangcj05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are good.

@wangcj05
Copy link
Collaborator

PR checklist is good.

@wangcj05 wangcj05 merged commit c823470 into devel Apr 16, 2024
12 checks passed
@wangcj05 wangcj05 deleted the alfoa/serpentInterfaceBugFixes branch April 16, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect devel issues in current devel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DEFECT] SimulatedAnnealing Opt fails with for 1 variable optimization
3 participants