Specialized Plot sub-directory ignoring (Fix) #2314
Conversation
…edAnnealingImplicitConstraint
removed jobhandler modification
…om:idaholab/raven into alfoa/simulatedAnnealingImplicitConstraint
| excType, excValue, excTrace = finishedRun[0].exceptionTrace | ||
| else: | ||
| # the failure happened at the input creation stage | ||
| excType, excValue, excTrace = IOError, IOError("Failure happened at the input creation stage. See trace above"), None |
There was a problem hiding this comment.
maybe related to the Genetic Algo issue with ensemble model
| @@ -742,7 +742,7 @@ def __advanceModel(self, identifier, modelToExecute, origInputList, inputKwargs, | |||
| # we evaluate the model directly | |||
| try: | |||
| evaluation = modelToExecute['Instance'].evaluateSample.original_function(modelToExecute['Instance'], origInputList, samplerType, inputKwargs) | |||
| except Exception as e: | |||
There was a problem hiding this comment.
e is not used anywhere
| @@ -54,7 +54,7 @@ def __init__(self): | |||
| self.printTag = 'OutStreamInterface' | |||
| self.overwrite = True # overwrite existing creations? | |||
| self.subDirectory = None # directory to save generated files to | |||
| self.filename = '' # target file name | |||
| self.filename = None # target file name | |||
There was a problem hiding this comment.
this is a better default to discern between case where the filename has been inputted and cases where has not
|
@PaulTalbot-INL I Added you as well since it touches the specialized plotting system you developed. |
| @@ -103,6 +104,7 @@ def run(self): | |||
| @ In, None | |||
| @ Out, None | |||
| """ | |||
| self.counter += 1 | |||
There was a problem hiding this comment.
this needs to be implemented for each specialized plotter we make, right? Is there a general way we can handle this so that it's not a hidden option for new plot development?
There was a problem hiding this comment.
Yes. Completely right. Fixed
There was a problem hiding this comment.
looks great, thank you!
|
Checklist is good. |
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Closes #2315
What are the significant changes in functionality due to this change request?
Now specialized plots in RAVEN consider the directory and the overwrite flag.
In addition, a couple of maintenance edits have been added in Serpent interface
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>to True.raven/tests/framework/user_guideandraven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.