-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filter to Moments page (index) #1994
Comments
Hey @julianguyen , if we want to filter by multiple traits, should we be using the |
@nad0m Correct, the |
@nad0m An |
Hey! I've just made this component, I wanted to ask what you think about the design or if you would change anything. ComponentWithReactInputMultiSelect.mp4 |
This looks great @franpb14! Can we change "Filter Moments posts by..." to "Filter by"? What do you think of placing the filter component to the right of the search bar? |
How exactly? as option A: optionA.mp4or as option B: optionB.mp4Personally I prefer option A because I think it is more intuitive, the user will know that they have to apply the filters first and then click on search. |
@franpb14 I think the Filter tool should be able to operate independently of the search bar. But yeah, filtering on a search should work too. I think B works well for that! Thanks for laying out the options :) |
… for moments This filter uses the new component to filter moments. Related issue is #1994.
I've added a new jsx which tests the new component and also I've modified some test for not repeat code.
… storybook I have also deleted some of my unneeded code #1994
I can see that this issue is linked to a year old PR, do you still want want help with this? @julianguyen |
@uzorjchibuzor Yeah there is a PR out that needs to be updated. I saw that you started work on #2116 so I would focus on that. I can look into this or someone else can pick it up! |
@julianguyen I see there has been some progress on this so far. Is the goal to just fix up some of the suggestions you made on the PR? |
… for moments This filter uses the new component to filter moments. Related issue is #1994.
I've added a new jsx which tests the new component and also I've modified some test for not repeat code.
… storybook I have also deleted some of my unneeded code #1994
Taking over this incomplete MR and taking it over the finish line 🏁 |
… for moments This filter uses the new component to filter moments. Related issue is #1994.
I've added a new jsx which tests the new component and also I've modified some test for not repeat code.
… storybook I have also deleted some of my unneeded code #1994
Description
It would be useful to be able to filter Moments posts by:
Filtering should work with the existing search feature as well. It might be worth being able to filter by multiple traits, so creating a new UI component for that would be necessary here.
Let's use our InputSelect component for this and place it beside the search bar
This issue requires more planning, so please plan things out it out in this issue :)
Please assign yourself (via the Assignees dropdown), if you do want to work on this issue. Can't find yourself? You need to join our organization.
Check out our Picking Up Issues guide if you haven't already!
The text was updated successfully, but these errors were encountered: