Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter to Moments page (index) #1994

Closed
julianguyen opened this issue Jun 20, 2021 · 11 comments
Closed

Add filter to Moments page (index) #1994

julianguyen opened this issue Jun 20, 2021 · 11 comments

Comments

@julianguyen
Copy link
Member

Description

It would be useful to be able to filter Moments posts by:

  • Secret Share enabled
  • No viewers
  • At least one viewer
  • Comments enabled
  • Draft enabled
  • Published

Filtering should work with the existing search feature as well. It might be worth being able to filter by multiple traits, so creating a new UI component for that would be necessary here.

Let's use our InputSelect component for this and place it beside the search bar

image

This issue requires more planning, so please plan things out it out in this issue :)


Please assign yourself (via the Assignees dropdown), if you do want to work on this issue. Can't find yourself? You need to join our organization.

Check out our Picking Up Issues guide if you haven't already!

@nad0m
Copy link
Contributor

nad0m commented Jun 21, 2021

Hey @julianguyen , if we want to filter by multiple traits, should we be using the InputSelect component? Not sure if I understand it correctly, but seems like the component only lets you select one option at a time.

@julianguyen
Copy link
Member Author

julianguyen commented Jun 21, 2021

@nad0m Correct, the InputSelect component only lets you select one option at a time. So we would have to create an InputMultiSelect component to be able to filter by multiple options.

@julianguyen
Copy link
Member Author

@nad0m An InputMultiSelect component could be similar to this one from Bootstrap.

@franpb14 franpb14 self-assigned this Aug 9, 2021
@franpb14
Copy link
Contributor

Hey! I've just made this component, I wanted to ask what you think about the design or if you would change anything.

ComponentWithReactInputMultiSelect.mp4

@julianguyen
Copy link
Member Author

This looks great @franpb14! Can we change "Filter Moments posts by..." to "Filter by"?

What do you think of placing the filter component to the right of the search bar?

@franpb14
Copy link
Contributor

franpb14 commented Aug 11, 2021

How exactly? as option A:

optionA.mp4

or as option B:

optionB.mp4

Personally I prefer option A because I think it is more intuitive, the user will know that they have to apply the filters first and then click on search.

@julianguyen
Copy link
Member Author

@franpb14 I think the Filter tool should be able to operate independently of the search bar. But yeah, filtering on a search should work too. I think B works well for that!

Thanks for laying out the options :)

franpb14 added a commit that referenced this issue Aug 29, 2021
… for moments

This filter uses the new component to filter moments. Related issue is #1994.
franpb14 added a commit that referenced this issue Sep 5, 2021
I've added a new jsx which tests the new component and also I've modified some test for not repeat code.
franpb14 added a commit that referenced this issue Sep 5, 2021
… storybook

I have also deleted some of my unneeded code #1994
@uzorjchibuzor
Copy link
Contributor

uzorjchibuzor commented Oct 21, 2022

I can see that this issue is linked to a year old PR, do you still want want help with this? @julianguyen
The assigned dev has done a lot of work on this. And the rest should be minor @franpb14

@julianguyen
Copy link
Member Author

@uzorjchibuzor Yeah there is a PR out that needs to be updated. I saw that you started work on #2116 so I would focus on that. I can look into this or someone else can pick it up!

@lucas-codes-stuff
Copy link

@julianguyen I see there has been some progress on this so far. Is the goal to just fix up some of the suggestions you made on the PR?

julianguyen pushed a commit that referenced this issue Feb 19, 2024
… for moments

This filter uses the new component to filter moments. Related issue is #1994.
julianguyen pushed a commit that referenced this issue Feb 19, 2024
I've added a new jsx which tests the new component and also I've modified some test for not repeat code.
julianguyen pushed a commit that referenced this issue Feb 19, 2024
… storybook

I have also deleted some of my unneeded code #1994
@julianguyen julianguyen self-assigned this Feb 19, 2024
@julianguyen
Copy link
Member Author

Taking over this incomplete MR and taking it over the finish line 🏁

julianguyen pushed a commit that referenced this issue Feb 20, 2024
… for moments

This filter uses the new component to filter moments. Related issue is #1994.
julianguyen pushed a commit that referenced this issue Feb 20, 2024
I've added a new jsx which tests the new component and also I've modified some test for not repeat code.
julianguyen pushed a commit that referenced this issue Feb 20, 2024
… storybook

I have also deleted some of my unneeded code #1994
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants