Feat/add filter moments page #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I haven't had a chance to take a look at this! Will do soon! |
julianguyen
reviewed
Oct 16, 2021
There was a problem hiding this comment.
Thanks so much for working on this! Sorry for the late review, it's been a busy month for me.
Let me know if you have any questions!
The other thing I noticed is if a user just has one Moment and the filter results in zero results, we display our experience when there are no moments:
It makes sense why we are showing this view, but I think it can be potentially confusing to users. We might actually just want to show all Moments when no filters match and indicate that no filters match.
… for moments This filter uses the new component to filter moments. Related issue is #1994.
|
I'm going to finish up this PR so we can merge it! :) |
I've added a new jsx which tests the new component and also I've modified some test for not repeat code.
… storybook I have also deleted some of my unneeded code #1994
julianguyen
force-pushed
the
feat/add-filter-moments-page
branch
from
c15b9a3 to
d985808
Compare
julianguyen
force-pushed
the
feat/add-filter-moments-page
branch
7 times, most recently
from
4e5e500 to
d012f3a
Compare
julianguyen
force-pushed
the
feat/add-filter-moments-page
branch
from
d012f3a to
4c4cd7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hello! I have made a new Input type with React ("multi_select") and I have added this with some filters to the moments.
More Details
React's component: I have created it looking a little bit at the implemented inputs and without using any new library. I have also added this component to the storybook and I have also added some tests.
Backend: I have added code to existing functions and added some methods to the helper. I have tried to make the code as reusable as possible in case, at some point, you want to do the same for other sections. I have also implemented new tests.
Note: there are some of the filters that are opposite so no moment is returned.
Note 2: I have corrected some messages in Spanish (my native language).
Last note: This is my first pull request with real code here, there are probably many things to correct, thanks to my reviewer in advance!
Corresponding Issue
#1994
Screenshots
Here is a working video:
Issue1994.mp4
And here is a screenshot of the mobile view
Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!