-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Ruby v3 and Rails v7 #2183
Conversation
The CI failure that's happening:
Looks like it's the result of needed to update the Ruby version in our Circle CI config. |
yes, it the ruby version on the CI build file, I changed it when I went to 3.0.3, then forgot to do the same when I moved to 3.1.2 |
The application is coming along nicely, I think I messed up the title part of the erb but I will fix that along the CI thing. oh, and the docker container has to go up too but that goes without saying. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for some reason that I have been unable to figure out, this line <title><%= render 'layouts/title' %></title>
at application.html.erb is not working as expected. The title bar looks wonky.
How can I have 4 failing tests locally and the CI blows up into the hundreds? :-) |
I'm getting as many test failures in CI when I check out your branch. Looks like it's predominantly:
This Stack Overflow post suggests you might want to pass a full filename (including the file extension). |
Can you show me a screenshot of what this looks like for you? |
@julianguyen Here is the screenshot of the title bar.. I will check the SO post for information. |
Just checking in, any updates here or anything I can help with? |
My charger got burnt and I just got a new one. I am trying to reset... |
I'm going to revisit this in a few weeks 💜 |
1112151
to
1479160
Compare
1479160
to
722c055
Compare
I added a couple of commits to fix the title issue and the rest of the broken specs. The tests are all passing locally (needed to set the Cloudinary env variables!) and I'm trying to figure out the why circle-ci is failing them. I suspect and am testing out a few things:
Will comment again if/when I figure it out |
Looks like CircleCi is working? Not sure why it says rspec is failing when there are no failing tests. I'm definitely not a circleci expert. |
Thanks for picking this up, I have been unable to make for it.
… On Apr 9, 2023, at 5:22 PM, Sean Marcia ***@***.***> wrote:
Looks like CircleCi is working? Not sure why it says rspec is failing when there are no failing tests. I'm definitely not a circleci expert.
—
Reply to this email directly, view it on GitHub <#2183 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHZNEUSUNBSYBZCGPHIGHUTXALO4PANCNFSM6AAAAAARNJD7FI>.
You are receiving this because you authored the thread.
|
56959c4
to
e6f6941
Compare
Still not sure why it is reporting rspec tests as failing. |
0d51df4
to
7a9974c
Compare
7a9974c
to
3cb1f81
Compare
Finally green. Looks like Circle-CI has issues with the latest version of simplecov so I had to downgrade it. There were also a couple of vulnerabilities that needed to be addressed but it looks like it is in a good place now. Any interest in setting up the CI in GitHub actions? |
Thanks so much for picking this up @seanmarcia! Sorry I couldn't review this a few weeks ago! Setting up with GitHub actions would be a great long-term route to explore, are you familiar with that Circle CI to GitHub actions conversion process @seanmarcia ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled things down locally and things looks good to me!
61c7001
to
3cb1f81
Compare
Closes #2116