-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Ruby v3 and Rails v7 #2183
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
fffaa77
application running with 16 rspec failures
uzorjchibuzor 16ceeec
ruby version updated to 2.7.2 as a milestone step
uzorjchibuzor 31ff147
application loading, tests failing
uzorjchibuzor ce3da52
moments index graph tests passing
uzorjchibuzor 38d424b
stepped ruby-version up to 3.0.3
uzorjchibuzor 48d0254
services and features are passing
uzorjchibuzor e4a351b
helpers specs passing
uzorjchibuzor 442ae91
4 failures in spec/models
uzorjchibuzor 9c4fe8f
models specs passing
uzorjchibuzor 85284df
requests specs are passing
uzorjchibuzor cf1c29b
tests are passing at this point empty commit, ruby 3.0.3 and rails 6.0
uzorjchibuzor a957300
add updated ruby version to cicleci
uzorjchibuzor 193ae10
rails v 6.0.6
uzorjchibuzor f6d3c52
fixed bug that was failing for ally to view moment and strategy
uzorjchibuzor 60096eb
bundle install for rails 6.1.7 completed okay
uzorjchibuzor 12b8aa3
checkpoint rails 6.1.7
uzorjchibuzor 18934e6
checkpoint rails 7.0.4 bundled
uzorjchibuzor 7b031eb
checkpoint: ran rails app:update
uzorjchibuzor c47a378
raised circle ci ruby version and dockerfile
uzorjchibuzor bf6f81f
fixed notifications spec test
uzorjchibuzor 22ee95a
removed node install follwing suggestion from CircleCI devOps support
uzorjchibuzor 86973f2
removed `ActionView::Helpers::AssetUrlHelper` as it has a conflict wi…
uzorjchibuzor 722c055
Rails 7 fixes
seanmarcia e69abd9
Merge branch 'main' into upgrade_ruby_3.1.2_rails_7
seanmarcia 3cb1f81
Bump ruby version to most recent semantic version in 3.1
seanmarcia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
2.6.10 | ||
3.1.4 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any specific reason why you removed this? It would be good to use a locked version of Node so that there's consistency across prod and dev.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed a suggestion from the DevOP from Circle CI. Will put it back as it did not fix my problem..