-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): add skip-proto
flag to s chain
command
#4019
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
requested review from
ilgooz,
jeronimoalbi and
Pantani
as code owners
March 14, 2024 13:13
github-actions
bot
added
component:ci
CI/CD workflow and automated jobs.
component:templates
component:configs
component:cmd
type:services
Service-related issues.
labels
Mar 14, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4019 +/- ##
==========================================
- Coverage 26.07% 26.06% -0.01%
==========================================
Files 304 304
Lines 25438 25440 +2
==========================================
- Hits 6632 6630 -2
- Misses 18230 18233 +3
- Partials 576 577 +1
|
Pantani
approved these changes
Mar 17, 2024
jeronimoalbi
approved these changes
Mar 18, 2024
mergify bot
pushed a commit
that referenced
this pull request
Mar 18, 2024
Adds a `--skip-proto` flag to `s chain` to speed up scaffolding. Advanced user can enjoy faster scaffolding time but still need to run `ignite chain serve` or `ignite chain build` afterwards. (cherry picked from commit c05237b) # Conflicts: # ignite/cmd/scaffold_chain.go # ignite/services/scaffolder/configs.go # ignite/services/scaffolder/init.go # ignite/services/scaffolder/params.go
julienrbrt
added a commit
that referenced
this pull request
Mar 19, 2024
#4030) * feat(cli): add `skip-proto` flag to `s chain` command (#4019) Adds a `--skip-proto` flag to `s chain` to speed up scaffolding. Advanced user can enjoy faster scaffolding time but still need to run `ignite chain serve` or `ignite chain build` afterwards. (cherry picked from commit c05237b) # Conflicts: # ignite/cmd/scaffold_chain.go # ignite/services/scaffolder/configs.go # ignite/services/scaffolder/init.go # ignite/services/scaffolder/params.go * fix conflicts --------- Co-authored-by: Julien Robert <julien@rbrt.fr>
Merged
julienrbrt
added a commit
that referenced
this pull request
May 29, 2024
Adds a `--skip-proto` flag to `s chain` to speed up scaffolding. Advanced user can enjoy faster scaffolding time but still need to run `ignite chain serve` or `ignite chain build` afterwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/v28.x.y
Backport to v28.x.y
component:ci
CI/CD workflow and automated jobs.
component:cmd
component:configs
component:templates
type:services
Service-related issues.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
--skip-proto
flag tos chain
to speed up scaffolding.Advanced user can enjoy faster scaffolding time but still need to run
ignite chain serve
orignite chain build
afterwards.