-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): add skip-proto
flag to s chain
command (backport #4019)
#4030
feat(cli): add skip-proto
flag to s chain
command (backport #4019)
#4030
Conversation
Adds a `--skip-proto` flag to `s chain` to speed up scaffolding. Advanced user can enjoy faster scaffolding time but still need to run `ignite chain serve` or `ignite chain build` afterwards. (cherry picked from commit c05237b) # Conflicts: # ignite/cmd/scaffold_chain.go # ignite/services/scaffolder/configs.go # ignite/services/scaffolder/init.go # ignite/services/scaffolder/params.go
Cherry-pick of c05237b has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v28.x.y #4030 +/- ##
===================================================
- Coverage 24.74% 24.74% -0.01%
===================================================
Files 297 297
Lines 24977 24979 +2
===================================================
Hits 6180 6180
- Misses 18229 18231 +2
Partials 568 568
|
The PR was automatically merged after the second approval but the CI was still running, I triggered it again because there was a failure which I believe it was a flaky test given that the origin of this backport worked. I believe merge should wait for the CI to finish, if that's possible. cc @julienrbrt |
Agree, we should make the same job as on main required on release branches. Cc @ilgooz |
Adds a
--skip-proto
flag tos chain
to speed up scaffolding.Advanced user can enjoy faster scaffolding time but still need to run
ignite chain serve
orignite chain build
afterwards.This is an automatic backport of pull request #4019 done by Mergify.