Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoscaling of merged tracks does not follow the current view of the region #1506

Closed
hoholee opened this issue May 11, 2022 · 5 comments
Closed

Comments

@hoholee
Copy link

hoholee commented May 11, 2022

Hi IGV team,

I was trying to make merged tracks with autoscale (related to #1473) using the following code (I'm using igv-webapp.1.10.8 and I believe it loads the latest igv.js 2.12.6):

                    {
                    "name": "Merged - autoscaled",
                    "type": "merged",
                    "autoscale": true,
		    "height": 50,
                    "tracks": [
                        {
                            "type": "wig",
                            "format": "bigwig",
                            "url": "https://www.encodeproject.org/files/ENCFF000ASJ/@@download/ENCFF000ASJ.bigWig",
                            "color": "red"
                        },
                        {
                            "type": "wig",
                            "format": "bigwig",
                            "url": "https://www.encodeproject.org/files/ENCFF351WPV/@@download/ENCFF351WPV.bigWig",
                            "color": "green"
                        }
                    ]
                },
                    {
                    "name": "track1",
                    "type": "wig",
                    "format": "bigwig",
		    "url": "https://www.encodeproject.org/files/ENCFF000ASJ/@@download/ENCFF000ASJ.bigWig",
		    "color": "red",
		    "height": 50,
                    "autoscale": true,
                    "autoscaleGroup": "group1"
                },
                    {
                    "name": "track2",
                    "type": "wig",
		    "format": "bigwig",
		    "url": "https://www.encodeproject.org/files/ENCFF351WPV/@@download/ENCFF351WPV.bigWig",
		    "color": "green",
		    "height": 50,
                    "autoscaleGroup": "group1"
                }

It seems to be working OK at this locus:
image

However, when I dragged the view a bit to the left I got this:
image

The two constitutive tracks autoscaled correctly (since the rightmost highest peaks are now out of view), but the merged tracks did not.

This seems to be something wrong in the merged track type where the y-axis range is not computed based on the values in the browser's current view (but somehow extended further to both sides)? Or am I missing something here?

@jrobinso
Copy link
Contributor

Yes I agree that seems to be a bug. I will look at it asap.

@julianstanley
Copy link

Screen.Recording.2022-05-17.at.15.48.24.mov

Just adding an additional demonstration of the same problem on the browser mentioned in #1473 after adding the 'autoscale': true flag, live demo here

@julianstanley
Copy link

Yes I agree that seems to be a bug. I will look at it asap.

Any update on this / hints on what's happening here? Happy to try to help if there's anything I can do.

@jrobinso
Copy link
Contributor

This is fixed, available in the main branch, and will be released by the end of the month.

@jrobinso
Copy link
Contributor

jrobinso commented Nov 3, 2022

Released as 2.13.4

@jrobinso jrobinso closed this as completed Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants