Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No different colors in 5C methylation representation #1895

Closed
vyx-lucy-kaplun opened this issue Sep 17, 2024 · 14 comments
Closed

No different colors in 5C methylation representation #1895

vyx-lucy-kaplun opened this issue Sep 17, 2024 · 14 comments

Comments

@vyx-lucy-kaplun
Copy link

Hi,
There is a problem with representation of methylation: 2-color system for 5mC (as well as any other system) displays all called 5C the same color. It is either all blue, all red, or all pink, but not different colors for methylated and not-methylated residues, as it is done in a desktop IGV version. Therefore, there is no way to see what is methylated and what is not. Is there a way to fix it? Thank you.

@jrobinso
Copy link
Contributor

I don't understand what you are asking, perhaps a screenshot would help. The colors and rules for applying them for base modifications are the same on IGV desktop and igv.js. Also, "5C" is not a call, did you mean 5mC?

@vyx-lucy-kaplun
Copy link
Author

My apologies, I should have attached screenshots right away. Here are two images to illustrate the difference: same bam file, same area, same settings (2-color, all).
Images to illustrate integrated IGV in DC vs desktop

@jrobinso
Copy link
Contributor

What version of igv.js are you using? I cannot reproduce that behavior, this is what I see with my test dataset, which contains 5mC and 5hmC calls.

Screenshot 2024-09-18 at 11 38 28 AM

@vyx-lucy-kaplun
Copy link
Author

We are on v. 3.0.5

@jrobinso
Copy link
Contributor

I will need to see your data, in addition to your track configuration. I am not able to reproduce your result. See my screenshot above. I don't need the entire BAM file, just the portion shown in your screenshot. You can use samtools to extract a slice. If needed send email to igv-team@broadinstitute.org and I will provide you with a link to a dropbox folder.

@vyx-lucy-kaplun
Copy link
Author

Sure, thank you! E-mailing you now.

@jrobinso
Copy link
Contributor

jrobinso commented Sep 19, 2024

Thanks for the test data. Below is what I see with the track configuration shown. I'm not really sure what could explain the difference, but could you try the exact configuration I am using with the bam file you sent us, and also double-check your igv.js version?

  {
                    type: 'alignment',
                    format:'bam',
                    visibilityWindow: 250_000,
                    samplingDepth: 50,
                    name: 'EXAMPLE',
                    url: "IGV_5mC_issue_chr15_23646787_23648567.bam",
                    indexURL: "IGV_5mC_issue_chr15_23646787_23648567.bam.csi",
                    displayMode: 'EXPANDED',
                    height: 400,
                    maxHeight: 500,
                    alignmentRowHeight: 15,
                    colorBy: 'basemod2',
                    showDeletionText: true
                }
Screenshot 2024-09-18 at 10 36 32 PM

@vyx-lucy-kaplun
Copy link
Author

vyx-lucy-kaplun commented Sep 19, 2024 via email

@vyx-lucy-kaplun
Copy link
Author

@jrobinso I believe we were able to pinpoint the issue with 5mC: it is related to CRAM format. The 2-color system works as expected when BAM format is used, but does not work with the same files in CRAM.

@jrobinso
Copy link
Contributor

jrobinso commented Oct 1, 2024

I can reproduce the error by converting the BAM file you sent to CRAM.

@jrobinso
Copy link
Contributor

jrobinso commented Oct 2, 2024

@vyx-lucy-kaplun Until this is fixed you won't be able to use CRAM files to view base modifications. I will update this issue when we release a fix.

@cmdcolin It seems that the "ML" tag, or perhaps any tag of type "B,C", is not correctly parsed. For example, on an alignment in which I expect an array of size 656 for the ML tag I get an array of size 144. The values are correct as far as they go, at least the first few values are correct, its just truncated.

@vyx-lucy-kaplun
Copy link
Author

@jrobinso Thank you!

@jrobinso
Copy link
Contributor

jrobinso commented Oct 3, 2024

This is fixed in release 3.0.7

@jrobinso jrobinso closed this as completed Oct 3, 2024
@vyx-lucy-kaplun
Copy link
Author

@jrobinso Thank you! It works now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants