bug fix - IGV js hangs and crashes browser if something is "off" in the url #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bug fix - when loading the igv, if you don't provide an explicit `queryParametersSupported: false` in the options object, the igv iterates over current query parameters looking for parameters of certain names (like 'file') and appends them to the config. and if, by any chance, you have corruption in the url (like we had an accidental `&&` in the middle), the igv loading hangs the browser (goes into infinite loop). this simple fix solves this (if a query param is somehow invalid, move on to the next)
eyal-elkevity
changed the title
|
Thanks for the fix. There might be another bug here as well, queryParametersSupported should default to false. Will look into that. |
jrobinso
added a commit
that referenced
this pull request
Feb 17, 2022
|
Hi Jim and thanks for the merge! Yes, I feel the same about the
queryParametersSupported config, I was surprised to see it defaults to
true, because if by any chance I'd had a query param with a matching name I
would get a weird config and would not understand why... feels like it
should be an explicit configuration. Actually my fix was to set this to
false, but after finding the bug in the igv code I felt the need to create
this patch. Thanks again :)
…On Thu, Feb 17, 2022 at 1:52 AM Jim Robinson ***@***.***> wrote:
Thanks for the fix. There might be another bug here as well,
queryParametersSupported should default to false. Will look into that.
—
Reply to this email directly, view it on GitHub
<#1461 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AL7ZNEYZPDWCVL6THKB7QS3U3Q2E5ANCNFSM5OLQLCGA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Yes they were both bugs, it defaults to "false" now. Thanks again for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug fix - when loading the igv, if you don't provide an explicit
queryParametersSupported: falsein the options object, the igv iterates over current query parameters looking for parameters of certain names (like 'file') and appends them to the config. and if, by any chance, you have corruption in the url (like we had an accidental&&in the middle), the igv loading hangs the browser (goes into infinite loop). this simple fix solves this (if a query param is somehow invalid, move on to the next)