-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add visibilityWindow for WigTrack #1540
Conversation
Tabix indexing a wig file is unusual, the normal method is bigWig. Displaying gwas data as a wig track is also unusual. I don't understand the tsv comment, "tsv" is not a track type, I think you are confusing file format with track type. |
Actually I don't understand the purpose of this PR, visibilityWindow for wig tracks is already supported. Could you provide a test case where this fails? |
Maybe I just haven't found the correct format and type settings for my situation. (You're right I was confusing type and format) In general, I want to (1) show numerical data on y-axis (either as line, bar or point graph), (2) the values are sparse (e.g. only on CpG sites) and (3) the data is in coordinate sorted bgzip compressed, tabix indexed tsv files with (4) arbitrary columns past the two to three initial columns for genomic coordinates. At least for me, this type of data is very common output of many analysis programs (e.g. this issue arose from using R package DSS for differential methylation calling and outputting a tsv with columns See below for All that being said, the presumed bug fixed by the pull request is quite mundane: without this, the browser loads the whole chromosome worth of data even for a small window, with this, only |
For the generic line plot / bargraph "bedgraph" is a reasonable format. "gwas" is a rather specialized format output by "plink" and similar programs. The format parameter is used to select a parser for the file. |
Ahh, I see the issue your PR addresses now, this looks good. |
Thanks for the merge. Sorry to use the pull request as a feature request but my format woes refer to the custom data column definition, which (I think) is only available for |
You're correct, the value column in bedgraph and most other formats is already defined, there is no flexibility (otherwise its not bedgraph). In some cases, such as "seg" format, it is always the last column. If I can reframe the request it would be support for generic tab delimited files. The syntax would be very similar to the gwas case, I don't see any way to make it less "clumsy", suggestions welcome. |
Now I think we've got understanding. I think the |
@kpalin If you want to open an issue for these suggestions it will lessen the chance they are forgotten. I did not invent the "gwas" format its a well known format by that name so I think that will remain as-is, the generalized form of this will not rely on that format. |
Enable (smaller) partial reading of indexed wig-like files. It's probably been a programming error to provide
windowFunction
instead ofvisibilityWindow
to that funciton.A different isssue: The UI for using tsv+bgzip+tabix for numerical data on arbitrary column is quite cumbersome. I managed with track:
note
type="wig", format="gwas"
. Plaintype="tsv"
would be nicer.