Fixing Golden bow sprite glowing pixels #8542
Conversation
|
Please, help me to find the place where the small artifact icons should be processed. |
zenseii
added
improvement
|
Hi, @shprotru. Could you please leave an image, preferably large, so that we can easily see the change done in this PR? |
src/fheroes2/agg/agg_image.cpp
Outdated
| @@ -3911,6 +3911,11 @@ namespace fheroes2 | |||
| case ICN::ARTIFACT: | |||
| LoadOriginalICN( id ); | |||
| if ( _icnVsSprite[id].size() > 99 ) { | |||
| // This fixes "Golden Bow" (#64) large artifact icon glowing yellow pixel | |||
| if ( _icnVsSprite[id][64].width() == 64 && _icnVsSprite[id][64].height() == 64 ) { | |||
There was a problem hiding this comment.
This check is not needed as Copy function will do the same.
|
Hi @ihhub ! I added |
There was a problem hiding this comment.
Hi, @shprotru.
I've checked this fix and all is OK - the glowing pixels are properly replaced with the correct ones:
Could you please, sync this PR with a master branch: we've added extra artifact image for Editor recently and used case ICN::ARTFX: in agg_image.cpp in the 4121 line.
And then updete this PR: the fix from current lines 3931-3934 should be moved the recently added case ICN::ARTFX: to properly merge this PR.
Co-authored-by: Sergei Ivanov (Districh) <113276641+Districh-ru@users.noreply.github.com>
fix #8520
after this fix:
vokoscreenNG-2024-04-06_00-08-20.mp4