Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Golden bow sprite glowing pixels #8542

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fixing Golden bow sprite glowing pixels #8542

Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6c9af87
large golden bow icon
shprotru Apr 4, 2024
443eba7
fix formatting
shprotru Apr 4, 2024
eb94e9e
no need to check image size
shprotru Apr 5, 2024
feab857
small golden bow icon
shprotru Apr 5, 2024
7731ad7
Merge remote-tracking branch 'upstream/master' into gbow_glowing_px
shprotru Jul 27, 2024
0275fa2
merged master
shprotru Jul 27, 2024
6084275
codestyle fix
shprotru Jul 27, 2024
ad67e74
Update src/fheroes2/agg/agg_image.cpp
shprotru Jul 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/fheroes2/agg/agg_image.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3911,6 +3911,9 @@ namespace fheroes2
case ICN::ARTIFACT:
LoadOriginalICN( id );
if ( _icnVsSprite[id].size() > 99 ) {
// This fixes "Golden Bow" (#64) large artifact icon glowing yellow pixel
Copy( _icnVsSprite[id][64], 35, 24, _icnVsSprite[id][64], 56, 12, 1, 1 );

// This fixes "Arm of the Martyr" (#88) and " Sphere of Negation" (#99) artifacts rendering which initially has some incorrect transparent pixels.
for ( const int32_t index : { 88, 99 } ) {
Sprite & originalImage = _icnVsSprite[id][index];
Expand All @@ -3923,6 +3926,13 @@ namespace fheroes2
}
}
return true;
case ICN::ARTFX:
LoadOriginalICN( id );
if ( _icnVsSprite[id].size() > 63 ) {
// This fixes "Golden Bow" (#63) small artifact icon glowing yellow pixel
Copy( _icnVsSprite[id][63], 12, 17, _icnVsSprite[id][63], 16, 12, 1, 1 );
}
return true;
case ICN::OBJNARTI:
LoadOriginalICN( id );
if ( _icnVsSprite[id].size() == 206 ) {
Expand Down