-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display video/bookshelf original URL (or canonical URL if possible!) to all users [ASIDE: upload of offline video works, despite red error "Failed to Move Cover File" in web UI] #107
Comments
Definitely! Other metadata is also urgently needed by educators & students too. Possibly including things like:
LATER ON ALSO: Film/Audio/Book criticism(s), keywords and/or ratings — contributed by "offline" Student/Volunteer Librarians. Related "canonicalized" URL discussion: Also related: |
@deldesir can we make this happen in June, to be refined later as nec? (Or if not yet, what higher-priority prep work needs to happen first?) |
No problem. Let's plan this for next week. |
(Pasted in from...) |
Regarding this PR just merged... ...a question for @deldesir:
|
Here's the technical answer to my question above — this is exactly what happened when I tried to upload 2.8MB OFFline video "sample-5s - Unknown.mp4" to LRN2:
(immediate screenshot of https://lrn2.org/live/admin/book/1000 below) (screenshot of https://lrn2.org/live/ below) (screenshot of https://lrn2.org/live/book/1000 below) In short, the process is rather ugly: (but at least it does work in the end, and "Original Internet URL:" field does not appear, which is the correct behavior!) Incidental URLs:
|
Upload of an OFFline photo works! Example of an 86.7 KB .WEBP photo just uploaded: (screenshot of https://lrn2.org/live/ below) (screenshot of https://lrn2.org/live/book/1001 below) (screenshot of https://lrn2.org/live/admin/book/1001 below) |
I will work on this. I'll use ffmpeg directly since our tests with https://github.com/smartcrop/smartcrop.py were not conclusive. |
Progress — I'm hoping this PR can be merged today [or very soon] — if it's confirmed to be solid: |
A bookshelf's original URL and key context (description etc!?) should also definitely be displayed for everyone (eventually, well before end of 2024 if possible!?) Right now bookshelves unfortunately don't provide any "lineage" details or "structural" details[*] except for the bookshelf title — as can be seen here:
[*] e.g. what is the average HH:MM:SS of every video on the shelf — to help all teachers/parents very quickly organize their lesson plan? |
Just FYI ugly HTML
Not an emergency and not the end of the world. But this should really be fixed. (Users should see "Original Internet URL: ..." on a completely separate line.) Related: |
The regression is fixed by upstream commit janeczku@551828f |
Is your feature request related to a problem? Please describe.
After I downloaded a video, I could not easily find the source URL from the Books or Edit Metadata page.
Describe the solution you'd like
When viewing or editing a downloaded media, in addition to publisher, it would be helpful to see the source URL. This can be for testing purposes (my use case), but I can also see educators wanting to view source URL to verify veracity or accuracy of content.
e.g., https://www.youtube.com/watch?v=OnTYLyNUPMc
Describe alternatives you've considered
I can see the source URL on the Tasks page, but this requires me inferring which video URL refers to which downloaded video available on the Books page. Also I expect that some educators using an IIAB install may not be Admins and hence not able to access the Tasks page.
Additional context
These are the 2 pages where seeing the source URL will be helpful. You could make it so that the field is not editable on the edit page if you want to restrict changing the URL after downlaoding.
The text was updated successfully, but these errors were encountered: