Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display video/bookshelf original URL (or canonical URL if possible!) to all users [ASIDE: upload of offline video works, despite red error "Failed to Move Cover File" in web UI] #107

Open
avni opened this issue Jan 20, 2024 · 12 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@avni
Copy link
Member

avni commented Jan 20, 2024

Is your feature request related to a problem? Please describe.
After I downloaded a video, I could not easily find the source URL from the Books or Edit Metadata page.

Describe the solution you'd like
When viewing or editing a downloaded media, in addition to publisher, it would be helpful to see the source URL. This can be for testing purposes (my use case), but I can also see educators wanting to view source URL to verify veracity or accuracy of content.
e.g., https://www.youtube.com/watch?v=OnTYLyNUPMc

Describe alternatives you've considered
I can see the source URL on the Tasks page, but this requires me inferring which video URL refers to which downloaded video available on the Books page. Also I expect that some educators using an IIAB install may not be Admins and hence not able to access the Tasks page.

Additional context
These are the 2 pages where seeing the source URL will be helpful. You could make it so that the field is not editable on the edit page if you want to restrict changing the URL after downlaoding.

Screenshot 2024-01-20 at 6 24 18 PM Screenshot 2024-01-20 at 6 24 27 PM
@holta holta added enhancement New feature or request question Further information is requested labels Jan 20, 2024
@holta
Copy link
Member

holta commented Jan 20, 2024

Definitely!

Other metadata is also urgently needed by educators & students too. Possibly including things like:

  • HH:MM:SS duration (of video, or audio recording)
  • Date of first publication
  • Provenance: Chain-of-Trust to Sources (beyond just URL)
  • Popularity
    • e.g. average "views" per day, according to YouTube or Vimeo or TikTok
    • e.g. total "offline" views, in your own school or community!

LATER ON ALSO: Film/Audio/Book criticism(s), keywords and/or ratings — contributed by "offline" Student/Volunteer Librarians.

Related "canonicalized" URL discussion:

Also related:

@holta holta pinned this issue Feb 8, 2024
@holta holta changed the title When viewing or editing a downloaded media, it would be helpful to see the source URL Display video/bookshelf original URL (or canonical URL if possible!) to all users Feb 9, 2024
@deldesir deldesir self-assigned this Feb 9, 2024
@holta
Copy link
Member

holta commented Jun 7, 2024

@deldesir can we make this happen in June, to be refined later as nec?

(Or if not yet, what higher-priority prep work needs to happen first?)

@deldesir
Copy link
Collaborator

deldesir commented Jun 8, 2024

No problem. Let's plan this for next week.

@holta
Copy link
Member

holta commented Jun 13, 2024

To Do:

  1. Many curriculum devs (parents, tutors, teachers, etc) will strongly prefer Source: URL on the very bottom of the description.

    To reduce distraction.

    “Offline First” is not just a slogan: this needs to be tried (soon).

  2. Other curatorial metadata like HH:MM:SS, e.g. video duration, will need to be surfaced far more prominently (for educators, kids, etc) in coming months — as summarized here:

    Display video/bookshelf original URL (or canonical URL if possible!) to all users [ASIDE: upload of offline video works, despite red error "Failed to Move Cover File" in web UI] #107 (comment)

(Pasted in from...)

@holta
Copy link
Member

holta commented Jun 14, 2024

Regarding this PR just merged...

...a question for @deldesir:

  1. I inserted the word "Internet" within "Original Internet URL:" to help educators/kids understand that the original video came from the ONline Internet...

  2. But what happens with this code when the original was an OFFline (local, grassroots community) video[*] — do you know?

[*] Or possibly even original OFFline photo??

@holta
Copy link
Member

holta commented Jun 14, 2024

  1. But what happens with this code when the original [was] an OFFline (local, grassroots community) video — do you know?

[@deldesir responded on PR #185:] An offline resource shared would be better identifiable by the the publisher name IMO. Could be an individual, an institution...

Here's the technical answer to my question above — this is exactly what happened when I tried to upload 2.8MB OFFline video "sample-5s - Unknown.mp4" to LRN2:

Failed to Move Cover File /library/calibre-web/Unknown/sample-5s - Unknown (1000): [Errno 2] No such file or directory: '/tmp/calibre_web/97da78f4fcd9095d11967496de38b04e.cover.jpg'

(immediate screenshot of https://lrn2.org/live/admin/book/1000 below)
image

(screenshot of https://lrn2.org/live/ below)
image

(screenshot of https://lrn2.org/live/book/1000 below)
image

In short, the process is rather ugly: (but at least it does work in the end, and "Original Internet URL:" field does not appear, which is the correct behavior!)

Incidental URLs:

@holta holta changed the title Display video/bookshelf original URL (or canonical URL if possible!) to all users Display video/bookshelf original URL (or canonical URL if possible!) to all users [ASIDE: upload of offline videos works, despite red error "Failed to Move Cover File" in web UI] Jun 14, 2024
@holta holta changed the title Display video/bookshelf original URL (or canonical URL if possible!) to all users [ASIDE: upload of offline videos works, despite red error "Failed to Move Cover File" in web UI] Display video/bookshelf original URL (or canonical URL if possible!) to all users [ASIDE: upload of offline video works, despite red error "Failed to Move Cover File" in web UI] Jun 14, 2024
@holta
Copy link
Member

holta commented Jun 14, 2024

[*] Or possibly even original OFFline photo??

Upload of an OFFline photo works! Example of an 86.7 KB .WEBP photo just uploaded:

(screenshot of https://lrn2.org/live/ below)
image

(screenshot of https://lrn2.org/live/book/1001 below)
image

(screenshot of https://lrn2.org/live/admin/book/1001 below)
image

@deldesir
Copy link
Collaborator

I will work on this. I'll use ffmpeg directly since our tests with https://github.com/smartcrop/smartcrop.py were not conclusive.

@holta
Copy link
Member

holta commented Jun 20, 2024

what happened when I tried to upload 2.8MB OFFline video "sample-5s - Unknown.mp4" to LRN2:

Failed to Move Cover File /library/calibre-web/Unknown/sample-5s - Unknown (1000): [Errno 2] No such file or directory: '/tmp/calibre_web/97da78f4fcd9095d11967496de38b04e.cover.jpg'

Progress — I'm hoping this PR can be merged today [or very soon] — if it's confirmed to be solid:

@holta
Copy link
Member

holta commented Jun 21, 2024

A bookshelf's original URL and key context (description etc!?) should also definitely be displayed for everyone (eventually, well before end of 2024 if possible!?)

Right now bookshelves unfortunately don't provide any "lineage" details or "structural" details[*] except for the bookshelf title — as can be seen here:

image
Screenshot from: https://lrn2.org/live/shelf/44

[*] e.g. what is the average HH:MM:SS of every video on the shelf — to help all teachers/parents very quickly organize their lesson plan?

@holta
Copy link
Member

holta commented Jul 5, 2024

Just FYI ugly HTML <br><br> tags are displayed, concatenated on the bottom of video description in many-if-not-most cases:

<br><br>Original Internet URL: ...

Not an emergency and not the end of the world. But this should really be fixed. (Users should see "Original Internet URL: ..." on a completely separate line.)

Related:

@deldesir
Copy link
Collaborator

The regression is fixed by upstream commit janeczku@551828f

@deldesir deldesir reopened this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants