Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uploader.py: Put "Original Internet URL" under description #185

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

@holta holta added the enhancement New feature or request label Jun 14, 2024
@holta holta requested a review from deldesir June 14, 2024 14:06
@holta
Copy link
Member Author

holta commented Jun 14, 2024

Tested on LRN2 (Ubuntu 24.04).

BEFORE...

image

AFTER...

image

Copy link
Collaborator

@deldesir deldesir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@holta holta merged commit 9e7f0bf into iiab:master Jun 14, 2024
@holta
Copy link
Member Author

holta commented Jun 14, 2024

@deldesir

  1. I inserted the word "Internet" within "Original Internet URL:" to help educators/kids understand that the original video came from the ONline Internet...

  2. But what happens with this code when the original was an OFFline (local, grassroots community) video[*] — do you know?

[*] Or possibly even original OFFline photo??

@holta
Copy link
Member Author

holta commented Jun 14, 2024

@deldesir
Copy link
Collaborator

deldesir commented Jun 14, 2024

  1. I inserted the word "Internet" within "Original Internet URL" to help educators/kids understand that the original video came from the ONline Internet...

That explains it.

  1. But what happens with this code when the original video came from an OFFline (local, grassroots community) video — do you know?

An offline resource shared would be better identifiable by the the publisher name IMO. Could be an individual, an institution...

@holta
Copy link
Member Author

holta commented Jul 5, 2024

This PR puts ugly, raw HTML tags <br><br> (visible to all users) in many-if-not-most cases.

This really should be fixed, as outlined at:

@deldesir
Copy link
Collaborator

This PR puts ugly, raw HTML tags <br><br> (visible to all users) in many-if-not-most cases.

This really should be fixed, as outlined at:

This regression is fixed by commit from upstream janeczku@551828f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants