Fix video upload failure [e.g. filenames that contain square brackets] #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Originally posted by @EMG70 in #203 (comment) |
holta
changed the title
|
It looks like this PR should have been reviewed more stringently — to ensure uploading works no matter what video/photo/MP3 filename is being uploaded — e.g. even when the filename contains unusual / abnormal characters etc: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes failures encountered when video downloaded with yt-dlp are uploaded manually via the upload button. It adds an additional logic to check if the video_id in the filename has a record in xklb-metadata.db (because these videos are generally named with their ids enclosed within brackets). This PR also ensures database is closed automatically, hence the indentation and the use of a context manager (
with sqlite3.connect(XKLB_DB_FILE) as conn)Fixes #203
Tested on Ubuntu 24.04 (LRN2)