-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strengthen video ID match [PROBLEM: videos with square brackets in their title do not download] #285
Conversation
Modify the code to correctly identify the last set of square brackets as containing the video ID
Tested on Ubuntu 24.04 with a clean Examples:
To properly test this PR with a previously failing video like Led Zeppelin - Stairway To Heaven (Live at Earls Court 1975) [Official Video]
Note:If you are using the SQLAlchemy-based refactoring outlined in this test plan after 11/16/2024, you are already covered. However, update the relevant branch if your IIAB was built on or before this date:
|
Post an example, right on top of this ticket. So that your thinking is crystal clear to others. Please. Thank you! |
CLARIF: This PR should be merged ASAP as soon as a vivid + clean example is posted (near the top of the ticket if possible!) Thereby allowing @avni to retest the following very promptly, and without hassle: |
|
Is this PR about videos whose title contains square brackets? (Are you saying that EXAMPLE 1. already downloaded correctly without the need for this PR?) (Whereas EXAMPLE 2. needs this PR to download correctly?) |
Yes,
Of course. I edited the explanation for better clarity. |
As explained in #284 (comment), IIAB Calibre-Web looks for video IDs inside square brackets ([...]) in the filenames. A video might have two sets of square brackets. This PR ensures video IDs are always correctly identified in the last set of square brackets.
This is also adjusted in SQLAlchemy-related code refactoring.