Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace f'{foo!r}' with f'{foo}'/repr(foo) #293

Closed
khaeru opened this issue Mar 25, 2020 · 0 comments · Fixed by #329
Closed

Replace f'{foo!r}' with f'{foo}'/repr(foo) #293

khaeru opened this issue Mar 25, 2020 · 0 comments · Fixed by #329

Comments

@khaeru
Copy link
Member

khaeru commented Mar 25, 2020

As noticed at #289 (comment) by @zikolach, !s, !r, and !a are redundant.

Like pandas-dev/pandas#29886, we need one PR to clean up all such usages in the code base at once. The style guide should also be updated at the same time.
@khaeru khaeru mentioned this issue Mar 25, 2020
Merged
3 tasks
@khaeru khaeru mentioned this issue May 28, 2020
Merged
3 tasks
@khaeru khaeru linked a pull request May 28, 2020 that will close this issue
Clean up prior to 3.0.0 #329
Merged
3 tasks
khaeru added a commit that referenced this issue May 28, 2020
@khaeru
Replace f'{foo!r}' with f'{foo}'/repr(foo) (#293)
f2982ab
@khaeru khaeru mentioned this issue May 28, 2020
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up prior to 3.0.0 iiasa/ixmp
1 participant
@khaeru