Replace "foo!r" to "repr(foo)" syntax #29886

ShaharNaveh · 2019-11-27T15:52:28Z

Since we are moving to f-strings and dropping old strings formats (% and .format()), we no longer need to have the redundant %r and !r specifiers, instead we use the repr() format.

Notes:

Don't forget to link this issue in your PR, paste this https://github.com/pandas-dev/pandas/issues/29886 in your PR.
If any of your changed files are related to Replace old string formatting syntax with f-strings #29547 , please make sure to link your pull request to that issue as well, simply paste this https://github.com/pandas-dev/pandas/issues/29547 in your pull request's body message as well.
Please comment what you are planning to work on, so we won't do double work.
If a file/files that should be marked as done, is'nt marked, please comment letting me know.

To check what files still needs to be fixed in the "pandas" directory:

grep -R -e '%r' -e '!r}' -e "'{}'" --include=*.{py,pyx} pandas/

Tip:

If you want to see the line number of the occurrence, replace the -l with -n
for example:

grep -n -R '%r' --include=*.{py,pyx} pandas/

The current list is:

Lastly:

Add a test case (so we won't regress)

The text was updated successfully, but these errors were encountered:

jbrockmendel · 2019-11-27T23:23:10Z

Another option that we use in quite a few places is single quotes "foo '{bar}' baz"

ShaharNaveh · 2019-11-27T23:40:07Z

Another option that we use in quite a few places is single quotes "foo '{bar}' baz"

@jbrockmendel I'm kinda obligated about how to find them systemically, meaning what if there's is a change to the repr() function, and the single quotas are there to differ from the repr() (If they're any). plus I'm not sure how to grep for this pattern.

ShaharNaveh · 2019-11-30T12:51:19Z

I'll take:

pandas/tests/tseries/offsets/test_fiscal.py
pandas/tests/tseries/offsets/test_offsets.py
pandas/tseries/offsets.py
pandas/util/testing.py

souravs17031999 · 2019-12-03T14:28:42Z

working on :

pandas/core/sorting.py
pandas/core/string.py
pandas/core/series.py

currently if no one has taken it yet.
will add more as i go further.

kvn219 · 2019-12-03T21:41:25Z

Working on: pandas/core/sorting.py

As described in the following issue pandas-dev#29886 , usage of !r is currently redundant and so changing to f strings in place of it.

souravs17031999 · 2019-12-04T04:38:09Z

hi @kvn219 , actually i am already working on three files one of which is what you have also mentioned , can you please work on some other file.

JvPy · 2019-12-04T21:22:55Z

I`ll take

pandas/pandas/io/parsers.py

pandas/pandas/io/html.py

…s.py" This reverts commit 182c68b.

EydenVillanueva · 2019-12-05T22:25:31Z

Hi to everyone, I will take:

pandas/_config/config.py
pandas/conftest.py
pandas/core/accessor.py
pandas/core/algorithms.py

ShaharNaveh · 2019-12-23T08:14:38Z

@WillAyd Can you please reopen this issue?

In this PR there is a use of the word fix and after that this PR number, so it closed it.

WillAyd · 2019-12-23T08:21:11Z

done - thanks!

AncientRickles · 2019-12-24T11:34:26Z

@WillAyd Can you please reopen this issue?

In this PR there is a use of the word fix and after that this PR number, so it closed it.

Sorry about that. Still kinda new to this...

ShaharNaveh · 2019-12-24T12:40:07Z

Sorry about that. Still kinda new to this...

It's perfectly fine :)

naomi172839 · 2019-12-25T18:07:35Z

pandas/tests/test_strings.py was checked and already uses f-strings.
pandas/core/dtypes/common.py was checked and already uses f-strings.
pandas/tests/indexes/test_common.py was checked and already uses f-strings.
pandas/core/window/rolling.py was checked and already uses f-strings.
pandas/core/computation/pytables.py was checked and already uses f-strings.
pandas/tests/indexes/datetimes/test_datetime.py was checked and already uses f-strings.
pandas/core/generic.py was checked and already uses f-strings.

If possible, it would be great to update the master list.

ShaharNaveh · 2019-12-25T18:11:54Z

pandas/tests/test_strings.py was checked and already uses f-strings.
pandas/core/dtypes/common.py was checked and already uses f-strings.
pandas/tests/indexes/test_common.py was checked and already uses f-strings.
pandas/core/window/rolling.py was checked and already uses f-strings.
pandas/core/computation/pytables.py was checked and already uses f-strings.
pandas/tests/indexes/datetimes/test_datetime.py was checked and already uses f-strings.
pandas/core/generic.py was checked and already uses f-strings.

If possible, it would be great to update the master list.

TY, really appreciate it

ShaharNaveh · 2019-12-25T22:32:45Z

@jreback Can you please reopen this issue?

The PR was suppose to contain two test cases, but it only contained one.

This should be reopen.

ShaharNaveh · 2019-12-25T22:57:52Z

Thanks @jreback

naomi172839 · 2019-12-26T00:12:20Z

pandas/core/arrays/datetimelike.py
pandas/core/arrays/period.py

Both of the above are free of the old style strings.
I am working on:
pandas/init.py

Fixed the remaining files. Signed-off-by: nbonnin <naomi172839@gmail.com>

naomi172839 · 2019-12-27T05:44:03Z

I tackled the remaining files. Did not implement a test though.

)

…ndexing-1row-df * upstream/master: (333 commits) CI: troubleshoot Web_and_Docs failing (pandas-dev#30534) WARN: Ignore NumbaPerformanceWarning in test suite (pandas-dev#30525) DEPR: camelCase in offsets, get_offset (pandas-dev#30340) PERF: implement scalar ops blockwise (pandas-dev#29853) DEPR: Remove Series.compress (pandas-dev#30514) ENH: Add numba engine for rolling apply (pandas-dev#30151) [ENH] Add to_markdown method (pandas-dev#30350) DEPR: Deprecate pandas.np module (pandas-dev#30386) ENH: Add ignore_index for df.drop_duplicates (pandas-dev#30405) BUG: The setting xrot=0 in DataFrame.hist() doesn't work with by and subplots pandas-dev#30288 (pandas-dev#30491) CI: Fix GBQ Tests (pandas-dev#30478) Bug groupby quantile listlike q and int columns (pandas-dev#30485) ENH: Add ignore_index for df.sort_values and series.sort_values (pandas-dev#30402) TYP: Typing hints in pandas/io/formats/{css,csvs}.py (pandas-dev#30398) BUG: raise on non-hashable Index name, closes pandas-dev#29069 (pandas-dev#30335) Replace "foo!r" to "repr(foo)" syntax pandas-dev#29886 (pandas-dev#30502) BUG: preserve EA dtype in transpose (pandas-dev#30091) BLD: add check to prevent tempita name error, clsoes pandas-dev#28836 (pandas-dev#30498) REF/TST: method-specific files for test_append (pandas-dev#30503) marked unused parameters (pandas-dev#30504) ...

TomAugspurger · 2019-12-30T17:33:14Z

So the only remaining item is a code check test for !r rather than repr?

TomAugspurger · 2019-12-30T17:33:42Z

Actually, it looks like we have a check for that. @MomIsBestFriend is there anything else to do here?

ShaharNaveh · 2019-12-30T19:59:49Z

@TomAugspurger I think not 😃

Thank you all for helping ❤️

ShaharNaveh changed the title ~~Replace redundant !r to expressive repr()~~ Replace redundant %r and !r to repr() Nov 27, 2019

simonjayhawkins added Code Style Code style, linting, code_checks good first issue labels Nov 27, 2019

ShaharNaveh changed the title ~~Replace redundant %r and !r to repr()~~ Replace "foo!r" to "repr(foo)" syntax Dec 3, 2019

souravs17031999 mentioned this issue Dec 3, 2019

changed "fun !r" -> "repr(fun)" #30002

Closed

5 tasks

kvn219 mentioned this issue Dec 3, 2019

Replaced !r with repr() #30020

Merged

4 tasks

souravs17031999 added a commit to souravs17031999/pandas that referenced this issue Dec 4, 2019

changed "fun !r" -> "repr(fun)"

54a8ff8

As described in the following issue pandas-dev#29886 , usage of !r is currently redundant and so changing to f strings in place of it.

souravs17031999 mentioned this issue Dec 4, 2019

changed "fun !r" -> "repr(fun)" #30032

Merged

5 tasks

souravs17031999 mentioned this issue Dec 4, 2019

changed "fun !r" -> "repr(fun)" souravs17031999/pandas#1

Merged

5 tasks

This was referenced Dec 4, 2019

STY: "{foo!r}" -> "{repr(foo)}" #30055

Merged

Replace old string formatting syntax with f-strings #29547

Closed

JvPy added a commit to JvPy/pandas that referenced this issue Dec 4, 2019

pandas-dev#29886 - Replace rm -rf pandas/ for repr() on parses.py

182c68b

JvPy added a commit to JvPy/pandas that referenced this issue Dec 5, 2019

Revert "pandas-dev#29886 - Replace rm -rf pandas/ for repr() on parse…

9b9f283

…s.py" This reverts commit 182c68b.

JvPy added a commit to JvPy/pandas that referenced this issue Dec 5, 2019

pandas-dev#29886 - Replace rm -rf pandas/ for repr() on parses.py

198c0a4

ShaharNaveh mentioned this issue Dec 5, 2019

STY: fstrings, repr pandas/io/html.py #30093

Merged

5 tasks

ShaharNaveh mentioned this issue Dec 5, 2019

CI: Checking in f-strings we use {repr(...)} instead of {...!r} #30099

Merged

10 tasks

WillAyd closed this as completed in #30420 Dec 23, 2019

WillAyd reopened this Dec 23, 2019

naomi172839 mentioned this issue Dec 25, 2019

STYLE: Use f-string in io/parsers #30466

Merged

jreback closed this as completed in #30099 Dec 25, 2019

jreback reopened this Dec 25, 2019

jreback modified the milestones: Contributions Welcome, 1.0 Dec 25, 2019

naomi172839 mentioned this issue Dec 26, 2019

STYLE: Using f-strings in pandas/__init__.py #30475

Merged

naomi172839 added a commit to naomi172839/pandas that referenced this issue Dec 27, 2019

Replace "foo!r" to "repr(foo)" syntax pandas-dev#29886

6bca907

Fixed the remaining files. Signed-off-by: nbonnin <naomi172839@gmail.com>

naomi172839 mentioned this issue Dec 27, 2019

Replace "foo!r" to "repr(foo)" syntax #29886 #30502

Merged

WillAyd pushed a commit that referenced this issue Dec 27, 2019

Replace "foo!r" to "repr(foo)" syntax #29886 (#30502)

95770df

AlexKirko pushed a commit to AlexKirko/pandas that referenced this issue Dec 29, 2019

Replace "foo!r" to "repr(foo)" syntax pandas-dev#29886 (pandas-dev#30502

72bbc2e

)

ShaharNaveh closed this as completed Dec 30, 2019

ShaharNaveh mentioned this issue Jan 14, 2020

TST: Insert 'match' to bare pytest raises #30997

Merged

5 tasks

This was referenced Mar 25, 2020

Transfer Excel data I/O from message_ix iiasa/ixmp#289

Merged

Replace f'{foo!r}' with f'{foo}'/repr(foo) iiasa/ixmp#293

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace "foo!r" to "repr(foo)" syntax #29886

Replace "foo!r" to "repr(foo)" syntax #29886

ShaharNaveh commented Nov 27, 2019 •

edited

Loading

jbrockmendel commented Nov 27, 2019

ShaharNaveh commented Nov 27, 2019

ShaharNaveh commented Nov 30, 2019 •

edited

Loading

souravs17031999 commented Dec 3, 2019 •

edited

Loading

kvn219 commented Dec 3, 2019 •

edited

Loading

souravs17031999 commented Dec 4, 2019

JvPy commented Dec 4, 2019 •

edited

Loading

EydenVillanueva commented Dec 5, 2019

ShaharNaveh commented Dec 23, 2019 •

edited

Loading

WillAyd commented Dec 23, 2019

AncientRickles commented Dec 24, 2019

ShaharNaveh commented Dec 24, 2019

naomi172839 commented Dec 25, 2019

ShaharNaveh commented Dec 25, 2019

ShaharNaveh commented Dec 25, 2019

ShaharNaveh commented Dec 25, 2019

naomi172839 commented Dec 26, 2019

naomi172839 commented Dec 27, 2019

TomAugspurger commented Dec 30, 2019

TomAugspurger commented Dec 30, 2019

ShaharNaveh commented Dec 30, 2019

Replace "foo!r" to "repr(foo)" syntax #29886

Replace "foo!r" to "repr(foo)" syntax #29886

Comments

ShaharNaveh commented Nov 27, 2019 • edited Loading

Notes:

Tip:

The current list is:

Lastly:

jbrockmendel commented Nov 27, 2019

ShaharNaveh commented Nov 27, 2019

ShaharNaveh commented Nov 30, 2019 • edited Loading

souravs17031999 commented Dec 3, 2019 • edited Loading

kvn219 commented Dec 3, 2019 • edited Loading

souravs17031999 commented Dec 4, 2019

JvPy commented Dec 4, 2019 • edited Loading

EydenVillanueva commented Dec 5, 2019

ShaharNaveh commented Dec 23, 2019 • edited Loading

WillAyd commented Dec 23, 2019

AncientRickles commented Dec 24, 2019

ShaharNaveh commented Dec 24, 2019

naomi172839 commented Dec 25, 2019

ShaharNaveh commented Dec 25, 2019

ShaharNaveh commented Dec 25, 2019

ShaharNaveh commented Dec 25, 2019

naomi172839 commented Dec 26, 2019

naomi172839 commented Dec 27, 2019

TomAugspurger commented Dec 30, 2019

TomAugspurger commented Dec 30, 2019

ShaharNaveh commented Dec 30, 2019

ShaharNaveh commented Nov 27, 2019 •

edited

Loading

ShaharNaveh commented Nov 30, 2019 •

edited

Loading

souravs17031999 commented Dec 3, 2019 •

edited

Loading

kvn219 commented Dec 3, 2019 •

edited

Loading

JvPy commented Dec 4, 2019 •

edited

Loading

ShaharNaveh commented Dec 23, 2019 •

edited

Loading