Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "foo!r" to "repr(foo)" syntax #29886 #30502

Merged
merged 5 commits into from
Dec 27, 2019

Conversation

naomi172839
Copy link
Contributor

@naomi172839 naomi172839 commented Dec 27, 2019

xref #29886
Fixed the remaining files in:

Replace "foo!r" to "repr(foo)" syntax #29886

Fixed the remaining files.

Signed-off-by: nbonnin <naomi172839@gmail.com>
@naomi172839 naomi172839 changed the title Finalfstrings Replace "foo!r" to "repr(foo)" syntax #29886 Dec 27, 2019
@naomi172839 naomi172839 marked this pull request as ready for review December 27, 2019 02:16
pandas/_version.py Outdated Show resolved Hide resolved
pandas/_version.py Outdated Show resolved Hide resolved
@WillAyd
Copy link
Member

WillAyd commented Dec 27, 2019

Does this close the issue mentioned in the OP?

@naomi172839
Copy link
Contributor Author

@WillAyd, the OP requested that a unit test be implemented as well. This has not been done yet

@alimcmaster1 alimcmaster1 added Clean Code Style Code style, linting, code_checks labels Dec 27, 2019
Signed-off-by: nbonnin <naomi172839@gmail.com>
pandas/_version.py Outdated Show resolved Hide resolved
Co-Authored-By: William Ayd <william.ayd@icloud.com>
@jreback jreback added this to the 1.0 milestone Dec 27, 2019
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. merge on green.

Signed-off-by: nbonnin <naomi172839@gmail.com>
@WillAyd WillAyd merged commit 95770df into pandas-dev:master Dec 27, 2019
@WillAyd
Copy link
Member

WillAyd commented Dec 27, 2019

Thanks!

AlexKirko pushed a commit to AlexKirko/pandas that referenced this pull request Dec 29, 2019
keechongtan added a commit to keechongtan/pandas that referenced this pull request Dec 29, 2019
…ndexing-1row-df

* upstream/master: (333 commits)
  CI: troubleshoot Web_and_Docs failing (pandas-dev#30534)
  WARN: Ignore NumbaPerformanceWarning in test suite (pandas-dev#30525)
  DEPR: camelCase in offsets, get_offset (pandas-dev#30340)
  PERF: implement scalar ops blockwise (pandas-dev#29853)
  DEPR: Remove Series.compress (pandas-dev#30514)
  ENH: Add numba engine for rolling apply (pandas-dev#30151)
  [ENH] Add to_markdown method (pandas-dev#30350)
  DEPR: Deprecate pandas.np module (pandas-dev#30386)
  ENH: Add ignore_index for df.drop_duplicates (pandas-dev#30405)
  BUG: The setting xrot=0 in DataFrame.hist() doesn't work with by and subplots pandas-dev#30288 (pandas-dev#30491)
  CI: Fix GBQ Tests (pandas-dev#30478)
  Bug groupby quantile listlike q and int columns (pandas-dev#30485)
  ENH: Add ignore_index for df.sort_values and series.sort_values (pandas-dev#30402)
  TYP: Typing hints in pandas/io/formats/{css,csvs}.py (pandas-dev#30398)
  BUG: raise on non-hashable Index name, closes pandas-dev#29069 (pandas-dev#30335)
  Replace "foo!r" to "repr(foo)" syntax pandas-dev#29886 (pandas-dev#30502)
  BUG: preserve EA dtype in transpose (pandas-dev#30091)
  BLD: add check to prevent tempita name error, clsoes pandas-dev#28836 (pandas-dev#30498)
  REF/TST: method-specific files for test_append (pandas-dev#30503)
  marked unused parameters (pandas-dev#30504)
  ...
@naomi172839 naomi172839 deleted the finalfstrings branch January 4, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants