Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STY: "{foo!r}" -> "{repr(foo)}" #batch-5 #29963

Merged
merged 13 commits into from
Dec 10, 2019
Merged

STY: "{foo!r}" -> "{repr(foo)}" #batch-5 #29963

merged 13 commits into from
Dec 10, 2019

Conversation

ShaharNaveh
Copy link
Member

@ShaharNaveh ShaharNaveh commented Dec 2, 2019 •
edited
Loading

@jreback jreback added the Code Style Code style, linting, code_checks label Dec 2, 2019
@ShaharNaveh ShaharNaveh marked this pull request as ready for review December 2, 2019 13:21
@jreback jreback added this to the 1.0 milestone Dec 2, 2019
@alimcmaster1
Copy link
Member

Please merge master

jreback
jreback requested changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would remove repr from all added places

pandas/tests/frame/test_analytics.py Outdated Show resolved Hide resolved
pandas/tests/indexes/datetimes/test_datetime.py Outdated Show resolved Hide resolved
pandas/tests/indexes/multi/test_integrity.py Show resolved Hide resolved
This was referenced Dec 5, 2019
Merged
Merged
jreback
jreback requested changes Dec 8, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one repr to remove, ping on green.

pandas/tests/frame/test_analytics.py Outdated Show resolved Hide resolved
@jreback
Copy link
Contributor

jreback commented Dec 8, 2019

lgtm ping on green

@ShaharNaveh
Copy link
Member Author

ping @jreback

@jreback jreback merged commit 419dd39 into pandas-dev:master Dec 10, 2019
@jreback
Copy link
Contributor

jreback commented Dec 10, 2019

thanks @MomIsBestFriend

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@ShaharNaveh @proost
STY: "{foo!r}" -> "{repr(foo)}" #batch-5 (pandas-dev#29963)
9a6c171
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@ShaharNaveh @proost
STY: "{foo!r}" -> "{repr(foo)}" #batch-5 (pandas-dev#29963)
a3af78f
@ShaharNaveh ShaharNaveh deleted the STY-repr-batch-5 branch December 20, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ShaharNaveh @alimcmaster1 @jreback @jbrockmendel