Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STY: F-strings and repr #29938

Merged
merged 2 commits into from
Dec 1, 2019
Merged

STY: F-strings and repr #29938

merged 2 commits into from
Dec 1, 2019

Conversation

ShaharNaveh
Copy link
Member

@ShaharNaveh ShaharNaveh commented Nov 30, 2019 •
edited
Loading

@ShaharNaveh ShaharNaveh changed the title F-strings and repr STY: F-strings and repr Nov 30, 2019
@ShaharNaveh ShaharNaveh force-pushed the STY-rerp-batch-1 branch 4 times, most recently from b0cb2f3 to d47596c Compare November 30, 2019 17:01
@jbrockmendel jbrockmendel added the Code Style Code style, linting, code_checks label Nov 30, 2019
WillAyd
WillAyd reviewed Nov 30, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally lgtm one question

pandas/tests/tseries/offsets/test_offsets.py Outdated Show resolved Hide resolved
@pep8speaks
Copy link

pep8speaks commented Nov 30, 2019 •
edited
Loading

Hello @MomIsBestFriend! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-11-30 21:34:46 UTC

@ShaharNaveh ShaharNaveh force-pushed the STY-rerp-batch-1 branch 2 times, most recently from 3af9255 to 7faf289 Compare November 30, 2019 21:32
@ShaharNaveh ShaharNaveh marked this pull request as ready for review November 30, 2019 22:06
@WillAyd WillAyd added this to the 1.0 milestone Dec 1, 2019
WillAyd
WillAyd approved these changes Dec 1, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jreback jreback merged commit 9f279b5 into pandas-dev:master Dec 1, 2019
@jreback
Copy link
Contributor

jreback commented Dec 1, 2019

thanks @MomIsBestFriend

if you would add a code-check for using r! would be great!

@ShaharNaveh
Copy link
Member Author

thanks @MomIsBestFriend

if you would add a code-check for using r! would be great!

Sure I'll just eliminate every occurrence of !r first

@jreback
Copy link
Contributor

jreback commented Dec 1, 2019

thanks @MomIsBestFriend :)

keechongtan added a commit to keechongtan/pandas that referenced this pull request Dec 2, 2019
@keechongtan
Merge remote-tracking branch 'upstream/master' into bug/categorical-i…
593dda1 
…ndexing-1row-df

* upstream/master: (49 commits)
  repr() (pandas-dev#29959)
  DOC : Typo fix in userguide/Styling (pandas-dev#29956)
  CLN: small things in pytables (pandas-dev#29958)
  API/DEPR: Change default skipna behaviour + deprecate numeric_only in Categorical.min and max (pandas-dev#27929)
  DEPR: DTI/TDI/PI constructor arguments (pandas-dev#29930)
  CLN: fix pytables passing too many kwargs (pandas-dev#29951)
  Typing (pandas-dev#29947)
  repr() (pandas-dev#29948)
  repr() (pandas-dev#29950)
  Added space at the end of the sentence (pandas-dev#29949)
  ENH: add NA scalar for missing value indicator, use in StringArray. (pandas-dev#29597)
  CLN: BlockManager.apply (pandas-dev#29825)
  TST: add test for rolling max/min/mean with DatetimeIndex over different frequencies (pandas-dev#29932)
  CLN: explicit signature for to_hdf (pandas-dev#29939)
  CLN: make kwargs explicit for pytables read_ methods (pandas-dev#29935)
  Convert core/indexes/base.py to f-strings (pandas-dev#29903)
  DEPR: dropna multiple axes, fillna int for td64, from_codes with floats, Series.nonzero (pandas-dev#29875)
  CLN: make kwargs explicit in pytables constructors (pandas-dev#29936)
  DEPR: tz_convert in the Timestamp constructor raises (pandas-dev#29929)
  STY: F-strings and repr (pandas-dev#29938)
  ...
moi90 added a commit to moi90/pandas that referenced this pull request Dec 9, 2019
@moi90
Revert divergence from pandas-dev#29938
263128d
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@ShaharNaveh @proost
STY: F-strings and repr (pandas-dev#29938)
e7be89e
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@ShaharNaveh @proost
STY: F-strings and repr (pandas-dev#29938)
51c53d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ShaharNaveh @pep8speaks @jreback @WillAyd @jbrockmendel