Separated docs and test apps #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijlee2
added
the
enhance: documentation
ijlee2
force-pushed
the
separate-docs-and-test-apps
branch
from
fd96ea5 to
02e6c10
Compare
….28 and 4.4 ember-try scenarios run
ijlee2
force-pushed
the
separate-docs-and-test-apps
branch
from
02e6c10 to
9420705
Compare
ijlee2
commented
Mar 8, 2023
| test-port: 7364 | ||
| - device: 'w3-h3' | ||
| test-port: 7365 | ||
| - 'embroider-optimized' |
There was a problem hiding this comment.
Previously, enabling embroider-optimized was not possible because the documentation app uses ember-css-modules. (In other words, the addon itself could always have passed embroider-optimized.)
ijlee2
commented
Mar 8, 2023
| @@ -1,6 +1,6 @@ | |||
| import { registerDestructor } from '@ember/destroyable'; | |||
| import { action } from '@ember/object'; | |||
| import { inject as service } from '@ember/service'; | |||
| import { service } from '@ember/service'; | |||
There was a problem hiding this comment.
Previously, we couldn't use the new syntax (introduced in Ember 4.1) because of the 3.28 scenario.
ijlee2
commented
Mar 8, 2023
Comment on lines
+14
to
+17
| '@ember/test-helpers': '2.7.0', | ||
| '@types/ember__test-helpers': '2.8.3', | ||
| '@types/ember-qunit': '6.1.1', | ||
| 'ember-qunit': '6.0.0', |
There was a problem hiding this comment.
Temporary solution to emberjs/ember-test-helpers#1232
ijlee2
commented
Mar 8, 2023
Comment on lines
+30
to
+31
| staticAddonTrees: false, // due to ember-css-modules | ||
| staticComponents: false, // due to ember-css-modules |
There was a problem hiding this comment.
TODO
If no further development to make ember-css-modules compatible with Embroider happens, consider removing the addon.
https://github.com/evoactivity/ember-modern-css#ember-modern-css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Since
v1.0.0, the test-app forember-container-queryhas served as a documentation app. As a result, whether the addon itself is compatible with the beta and canary versions of Ember as well as Embroider (according toember-try) has depended on whether the documentation app is compatible with them.What changed?
I created a package called
docs-app, which runs on the latest version of Ember and the strictest settings from Embroider. The application tests (e.g. Percy snapshots), in particular, document what end-developers can expect to see fromember-container-query.The
test-appnow contains the rendering tests for the<ContainerQuery>component, the 3 helpers, and the modifier. These tests are run under variousember-tryscenarios. Note thatember-canaryandembroider-optimizedare now enabled.