-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separated docs and test apps #165
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
b6f07d0
chore: Created docs-app package
ijlee2 47d2281
chore: Removed irrelevant code (docs-app)
ijlee2 fbc0ce9
chore: Removed ember-try (docs-app)
ijlee2 24f3286
chore: Separated testing concerns (docs-app)
ijlee2 988c4d3
feature: Introduced Embroider with no options (docs-app)
ijlee2 b693f6f
chore: Ran yarn install and yarn-deduplicate
ijlee2 7c4ebdd
feature: Enabled stricter Embroider settings and route splitting (doc…
ijlee2 5966757
chore: Removed ember-cli-typescript (docs-app)
ijlee2 9acc144
chore: Updated Ember syntax (docs-app)
ijlee2 afa9299
chore: Removed irrelevant code (test-app)
ijlee2 c11a5e9
chore: Removed ember-cli-typescript (test-app)
ijlee2 97826c0
chore: Removed unused packages (test-app)
ijlee2 9505704
chore: Ran yarn install
ijlee2 9fb29d5
chore: Updated CONTRIBUTING and README
ijlee2 fbba998
chore: Updated CI workflow
ijlee2 9420705
chore: Temporarily downgraded @ember/test-helpers to v2.7.0 so that 3…
ijlee2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| /** | ||
| Ember CLI sends analytics information by default. The data is completely | ||
| anonymous, but there are times when you might want to disable this behavior. | ||
|
|
||
| Setting `disableAnalytics` to true will prevent any data from being sent. | ||
| */ | ||
| "disableAnalytics": false, | ||
|
|
||
| /** | ||
| Setting `isTypeScriptProject` to true will force the blueprint generators to generate TypeScript | ||
| rather than JavaScript by default, when a TypeScript version of a given blueprint is available. | ||
| */ | ||
| "isTypeScriptProject": false | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # unconventional js | ||
| /blueprints/*/files/ | ||
| /vendor/ | ||
|
|
||
| # compiled output | ||
| /dist/ | ||
| /tmp/ | ||
|
|
||
| # dependencies | ||
| /bower_components/ | ||
| /node_modules/ | ||
|
|
||
| # misc | ||
| /coverage/ | ||
| !.* | ||
| .*/ | ||
| .eslintcache | ||
|
|
||
| # ember-try | ||
| /.node_modules.ember-try/ | ||
| /bower.json.ember-try | ||
| /npm-shrinkwrap.json.ember-try | ||
| /package.json.ember-try | ||
| /package-lock.json.ember-try | ||
| /yarn.lock.ember-try |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| 'use strict'; | ||
|
|
||
| module.exports = { | ||
| root: true, | ||
| parser: '@typescript-eslint/parser', | ||
| parserOptions: { | ||
| ecmaVersion: 2018, | ||
| }, | ||
| plugins: [ | ||
| 'ember', | ||
| '@typescript-eslint', | ||
| 'simple-import-sort', | ||
| 'typescript-sort-keys', | ||
| ], | ||
| extends: [ | ||
| 'eslint:recommended', | ||
| 'plugin:ember/recommended', | ||
| 'plugin:prettier/recommended', | ||
| ], | ||
| env: { | ||
| browser: true, | ||
| }, | ||
| rules: { | ||
| curly: 'error', | ||
| 'simple-import-sort/exports': 'error', | ||
| 'simple-import-sort/imports': 'error', | ||
| }, | ||
| overrides: [ | ||
| // TypeScript files | ||
| { | ||
| files: ['**/*.ts'], | ||
| extends: [ | ||
| 'plugin:@typescript-eslint/eslint-recommended', | ||
| 'plugin:@typescript-eslint/recommended', | ||
| 'plugin:typescript-sort-keys/recommended', | ||
| ], | ||
| rules: { | ||
| '@typescript-eslint/no-empty-interface': 'off', | ||
| '@typescript-eslint/no-explicit-any': 'off', | ||
| '@typescript-eslint/no-non-null-assertion': 'off', | ||
| }, | ||
| }, | ||
| // Node files | ||
| { | ||
| files: [ | ||
| './.eslintrc.js', | ||
| './.prettierrc.js', | ||
| './.stylelintrc.js', | ||
| './.template-lintrc.js', | ||
| './ember-cli-build.js', | ||
| './testem.js', | ||
| './blueprints/*/index.js', | ||
| './config/**/*.js', | ||
| './lib/*/index.js', | ||
| './server/**/*.js', | ||
| ], | ||
| env: { | ||
| browser: false, | ||
| node: true, | ||
| }, | ||
| extends: ['plugin:n/recommended'], | ||
| }, | ||
| // Test files | ||
| { | ||
| files: ['tests/**/*-test.{js,ts}'], | ||
| extends: ['plugin:qunit/recommended'], | ||
| }, | ||
| ], | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # See https://help.github.com/ignore-files/ for more about ignoring files. | ||
|
|
||
| # compiled output | ||
| /dist/ | ||
| /tmp/ | ||
|
|
||
| # dependencies | ||
| /bower_components/ | ||
| /node_modules/ | ||
|
|
||
| # misc | ||
| /.env* | ||
| /.pnp* | ||
| /.DS_Store | ||
| /.sass-cache | ||
| /.eslintcache | ||
| /.stylelintcache | ||
| /connect.lock | ||
| /coverage/ | ||
| /libpeerconnection.log | ||
| /npm-debug.log* | ||
| /testem.log | ||
| /yarn-error.log | ||
|
|
||
| # ember-try | ||
| /.node_modules.ember-try/ | ||
| /bower.json.ember-try | ||
| /npm-shrinkwrap.json.ember-try | ||
| /package.json.ember-try | ||
| /package-lock.json.ember-try | ||
| /yarn.lock.ember-try | ||
|
|
||
| # broccoli-debug | ||
| /DEBUG/ |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # unconventional js | ||
| /blueprints/*/files/ | ||
| /vendor/ | ||
|
|
||
| # compiled output | ||
| /dist/ | ||
| /tmp/ | ||
|
|
||
| # dependencies | ||
| /bower_components/ | ||
| /node_modules/ | ||
|
|
||
| # misc | ||
| /coverage/ | ||
| !.* | ||
| .eslintcache | ||
| .lint-todo/ | ||
|
|
||
| # ember-try | ||
| /.node_modules.ember-try/ | ||
| /bower.json.ember-try | ||
| /npm-shrinkwrap.json.ember-try | ||
| /package.json.ember-try | ||
| /package-lock.json.ember-try | ||
| /yarn.lock.ember-try |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| 'use strict'; | ||
|
|
||
| module.exports = { | ||
| printWidth: 80, | ||
| singleQuote: true, | ||
|
|
||
| overrides: [ | ||
| { | ||
| files: '*.hbs', | ||
| options: { | ||
| printWidth: 64, | ||
| singleQuote: false, | ||
| }, | ||
| }, | ||
| ], | ||
| }; |
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously, enabling
embroider-optimizedwas not possible because the documentation app usesember-css-modules. (In other words, the addon itself could always have passedembroider-optimized.)