feat(server,web): hide faces

[martabal]

This PR adds the ability to hide people from asset viewer & explore page.

To do:

• move the logic from the client to server
• fix bugs
• simplify the user-page-layout
• add server tests

2023-07-16.22-57-37.mp4

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
immich	⬜️ Ignored (Inspect)	Visit Preview		Jul 18, 2023 6:05pm

[jrasm91]

Looks like a good start. A few notes:

• We can definitely filter out people when we get asset details. That could even be in the response dto mapper for now.
• I think the people endpoint needs to be able to return hidden people, so that we can use it to show a list that the user can toggle, although we do want to hide them on the explore page. We can keep filtering that client-side or have a query param to show hidden, and exclude them by default.
• In general we have isAdmin, isArchived, isFavorite, isVisible, etc. Maybe it would be more consistent to have this be called isHidden.

[martabal]

Looks like a good start. A few notes:

* We can definitely filter out people when we get asset details. That could even be in the response dto mapper for now.

* I think the people endpoint needs to be able to return hidden people, so that we can use it to show a list that the user can toggle, although we do want to hide them on the explore page. We can keep filtering that client-side or have a query param to show hidden, and exclude them by default.

* In general we have `isAdmin`, `isArchived`, `isFavorite`, `isVisible`, etc. Maybe it would be more consistent to have this be called `isHidden`.

Thank you for your feedback !

[martabal]

I added more use cases with view all and show & hide faces buttons

2023-07-16.12-03-22.mp4

[alextran1502]

The latest video doesn't indicate that if you hide faces, how can you unhide them?

[martabal]

The latest video doesn't indicate that if you hide faces, how can you unhide them?

The notification is hiding the Show & hide faces button which allow to hide and unhide faces, I have updated the video

[jrasm91]

I think that is ok. It is unlikely to be a problem unless they're doing 100 or more. Even then, they're probably only going to do it once. So I think it's ok to not optimize by adding a new endpoint.

[jrasm91]

Code looks good to me.