Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewriter: hypothetical lifetime parameters not added to types in function signatures #921

Closed
aneksteind opened this issue May 10, 2023 · 4 comments · Fixed by #1000
Closed
Assignees

Comments

@aneksteind
Copy link
Contributor

aneksteind commented May 10, 2023

For a function signature such as

fn foo<'d>(ra: &'d mut A<'d>, ppd: *mut *mut Data<'d>) {

If hypothetical lifetimes are introduced for ppd: &'h0 &'h1 Data<'d>and Data gets a hypothetical lifetime and updated to Data<'d, 'h2> we'd like the rewriter to generate:

fn foo<'d, 'h0, 'h1, 'h2>(ra: &'d mut A<'d>, ppd: &'h0 &'h1 Data<'d, h2>) {
@aneksteind
Copy link
Contributor Author

cc @kkysen this is a potential task for you to take on in the next month if you run out of other things to do. otherwise i can get to it when i'm back

@kkysen
Copy link
Contributor

kkysen commented May 10, 2023

Sure. What's the current behavior of the rewriter?

@aneksteind
Copy link
Contributor Author

aneksteind commented May 10, 2023

It avoids liftime rewrites for all non-field types

@aneksteind aneksteind changed the title Rewriter does not introduce hypothetical lifetime parameters to function signatures rewriter: hypothetical lifetime parameters not added to types in function signatures Jun 13, 2023
@aneksteind
Copy link
Contributor Author

I'm working on this, so assigning just myself for the time being

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants