Add hypothetical lifetime parameters and arguments to function signatures #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aneksteind
force-pushed
the
feat.rewrite.fns
branch
9 times, most recently
from
108e7b4 to
d22ee19
Compare
aneksteind
changed the title
aneksteind
force-pushed
the
feat.rewrite.fns
branch
from
2bbefc8 to
07e133e
Compare
aneksteind
commented
Jul 28, 2023
aneksteind
commented
Jul 28, 2023
| @@ -61,9 +61,9 @@ struct HypoWrapper { | |||
|
|
|||
| // CHECK-LABEL: final labeling for "_field_access" | |||
| // CHECK-DAG: ([[@LINE+3]]: ppd): addr_of = UNIQUE, type = READ | WRITE | UNIQUE | |||
| // CHECK-DAG: ([[@LINE+2]]: ra): &mut A | |||
| // CHECK-DAG: ([[@LINE+2]]: ra): &'d mut A<'d> | |||
| // CHECK-DAG: ([[@LINE+1]]: ppd): &mut &mut Data | |||
There was a problem hiding this comment.
In another PR I'd like to add hypothetical params to this label
aneksteind
commented
Jul 28, 2023
aneksteind
force-pushed
the
feat.rewrite.fns
branch
from
b03f205 to
3297742
Compare
spernsteiner
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Looks about right to me.
Regarding the conflict: in #1005 (merged yesterday), I pulled the struct rewriting logic out of HirTyVisitor::visit_item to avoid O(N^2) behavior (each time we ran rewriting on a function, it also generated all struct rewrites) and give main.rs more control over what gets rewritten. You'll probably have to move the new gen_generics_rws calls out of visit_item as well.
aneksteind
force-pushed
the
feat.rewrite.fns
branch
from
4a07a01 to
1c39f40
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #921 and fixes #927