Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: use npm publish #304

Closed
wants to merge 1 commit into from
Closed

Conversation

RobinTail
Copy link
Contributor

@RobinTail RobinTail commented Jul 17, 2024

Copy link

changeset-bot bot commented Jul 17, 2024

⚠️ No Changeset found

Latest commit: 234dca4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@RobinTail
Copy link
Contributor Author

@SukkaW || @JounQin , please review

@RobinTail
Copy link
Contributor Author

@SukkaW || @JounQin , please review

@SukkaW
Copy link
Collaborator

SukkaW commented Jul 19, 2024

IMHO I don't see switching to npm publish would help in this case. Would you mind explaining any difference between yarn release and npm publish here?

@RobinTail
Copy link
Contributor Author

RobinTail commented Jul 19, 2024

Would you mind explaining any difference

I just know that npm works for publishing into the NPM registry.
I always use npm publish myself despite using yarn for everything else.
The link in the description proves that yarn release may cause unexplainable issues.
Since this is exactly what we're currently dealing with ("package is not in the registry" error, while it is clearly there), I'm suggesting to give it a try.
Can not explain it better. But if it will work — we would fix the publishing issue. If not — it's easy to revert, @SukkaW

@SukkaW
Copy link
Collaborator

SukkaW commented Jul 19, 2024

The link in the description proves that yarn release may cause unexplainable issues.

The StackOverflow question doesn't mention yarn anywhere other than description in the example package.json:

image

On the other hand, yarn release is not a yarn built-in command. It is a project-wide custom script:

"release": "changeset publish",

Closing the PR.

@SukkaW SukkaW closed this Jul 19, 2024
@RobinTail
Copy link
Contributor Author

Is there a plan to do something better than this and fix the release, @SukkaW ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants