-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#303): use @nolyfill/is-core-module
#305
Conversation
🦋 Changeset detectedLatest commit: 9255279 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/restore-cursor@4.0.0 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't run the match against the Node.js version
I'm not sure if this is an advantage
I wouldn't mind going back to using is-core-module
(or maybe prefer that, since 72 kib size and 2 deps is not an issue for me), but this is ok too
I will go back to |
| datasource | package | from | to | | ---------- | --------------------------------- | ----- | ----- | | npm | eslint-import-resolver-typescript | 3.6.1 | 3.6.3 | ## [v3.6.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#363) ##### Patch Changes - [#305](import-js/eslint-import-resolver-typescript#305) [`f8d7b82`](import-js/eslint-import-resolver-typescript@f8d7b82) Thanks [@SukkaW](https://github.com/SukkaW)! - Fix resolve for `node:test`, `node:sea`, and `node:sqlite` without sacrificing installation size - [#288](import-js/eslint-import-resolver-typescript#288) [`a4c6c78`](import-js/eslint-import-resolver-typescript@a4c6c78) Thanks [@SunsetTechuila](https://github.com/SunsetTechuila)! - fix: ignore bun built-in modules
| datasource | package | from | to | | ---------- | --------------------------------- | ----- | ----- | | npm | eslint-import-resolver-typescript | 3.6.1 | 3.6.3 | ## [v3.6.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#363) ##### Patch Changes - [#305](import-js/eslint-import-resolver-typescript#305) [`f8d7b82`](import-js/eslint-import-resolver-typescript@f8d7b82) Thanks [@SukkaW](https://github.com/SukkaW)! - Fix resolve for `node:test`, `node:sea`, and `node:sqlite` without sacrificing installation size - [#288](import-js/eslint-import-resolver-typescript#288) [`a4c6c78`](import-js/eslint-import-resolver-typescript@a4c6c78) Thanks [@SunsetTechuila](https://github.com/SunsetTechuila)! - fix: ignore bun built-in modules
| datasource | package | from | to | | ---------- | --------------------------------- | ----- | ----- | | npm | eslint-import-resolver-typescript | 3.6.1 | 3.6.3 | ## [v3.6.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#363) ##### Patch Changes - [#305](import-js/eslint-import-resolver-typescript#305) [`f8d7b82`](import-js/eslint-import-resolver-typescript@f8d7b82) Thanks [@SukkaW](https://github.com/SukkaW)! - Fix resolve for `node:test`, `node:sea`, and `node:sqlite` without sacrificing installation size - [#288](import-js/eslint-import-resolver-typescript#288) [`a4c6c78`](import-js/eslint-import-resolver-typescript@a4c6c78) Thanks [@SunsetTechuila](https://github.com/SunsetTechuila)! - fix: ignore bun built-in modules
| datasource | package | from | to | | ---------- | --------------------------------- | ----- | ----- | | npm | eslint-import-resolver-typescript | 3.6.1 | 3.6.3 | ## [v3.6.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#363) ##### Patch Changes - [#305](import-js/eslint-import-resolver-typescript#305) [`f8d7b82`](import-js/eslint-import-resolver-typescript@f8d7b82) Thanks [@SukkaW](https://github.com/SukkaW)! - Fix resolve for `node:test`, `node:sea`, and `node:sqlite` without sacrificing installation size - [#288](import-js/eslint-import-resolver-typescript#288) [`a4c6c78`](import-js/eslint-import-resolver-typescript@a4c6c78) Thanks [@SunsetTechuila](https://github.com/SunsetTechuila)! - fix: ignore bun built-in modules
| datasource | package | from | to | | ---------- | --------------------------------- | ----- | ----- | | npm | eslint-import-resolver-typescript | 3.6.1 | 3.6.3 | ## [v3.6.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#363) ##### Patch Changes - [#305](import-js/eslint-import-resolver-typescript#305) [`f8d7b82`](import-js/eslint-import-resolver-typescript@f8d7b82) Thanks [@SukkaW](https://github.com/SukkaW)! - Fix resolve for `node:test`, `node:sea`, and `node:sqlite` without sacrificing installation size - [#288](import-js/eslint-import-resolver-typescript#288) [`a4c6c78`](import-js/eslint-import-resolver-typescript@a4c6c78) Thanks [@SunsetTechuila](https://github.com/SunsetTechuila)! - fix: ignore bun built-in modules
| datasource | package | from | to | | ---------- | --------------------------------- | ----- | ----- | | npm | eslint-import-resolver-typescript | 3.6.1 | 3.6.3 | ## [v3.6.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#363) ##### Patch Changes - [#305](import-js/eslint-import-resolver-typescript#305) [`f8d7b82`](import-js/eslint-import-resolver-typescript@f8d7b82) Thanks [@SukkaW](https://github.com/SukkaW)! - Fix resolve for `node:test`, `node:sea`, and `node:sqlite` without sacrificing installation size - [#288](import-js/eslint-import-resolver-typescript#288) [`a4c6c78`](import-js/eslint-import-resolver-typescript@a4c6c78) Thanks [@SunsetTechuila](https://github.com/SunsetTechuila)! - fix: ignore bun built-in modules
| datasource | package | from | to | | ---------- | --------------------------------- | ----- | ----- | | npm | eslint-import-resolver-typescript | 3.6.1 | 3.6.3 | ## [v3.6.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#363) ##### Patch Changes - [#305](import-js/eslint-import-resolver-typescript#305) [`f8d7b82`](import-js/eslint-import-resolver-typescript@f8d7b82) Thanks [@SukkaW](https://github.com/SukkaW)! - Fix resolve for `node:test`, `node:sea`, and `node:sqlite` without sacrificing installation size - [#288](import-js/eslint-import-resolver-typescript#288) [`a4c6c78`](import-js/eslint-import-resolver-typescript@a4c6c78) Thanks [@SunsetTechuila](https://github.com/SunsetTechuila)! - fix: ignore bun built-in modules
| datasource | package | from | to | | ---------- | --------------------------------- | ----- | ----- | | npm | eslint-import-resolver-typescript | 3.6.1 | 3.6.3 | ## [v3.6.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#363) ##### Patch Changes - [#305](import-js/eslint-import-resolver-typescript#305) [`f8d7b82`](import-js/eslint-import-resolver-typescript@f8d7b82) Thanks [@SukkaW](https://github.com/SukkaW)! - Fix resolve for `node:test`, `node:sea`, and `node:sqlite` without sacrificing installation size - [#288](import-js/eslint-import-resolver-typescript#288) [`a4c6c78`](import-js/eslint-import-resolver-typescript@a4c6c78) Thanks [@SunsetTechuila](https://github.com/SunsetTechuila)! - fix: ignore bun built-in modules
| datasource | package | from | to | | ---------- | --------------------------------- | ----- | ----- | | npm | eslint-import-resolver-typescript | 3.6.1 | 3.6.3 | ## [v3.6.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#363) ##### Patch Changes - [#305](import-js/eslint-import-resolver-typescript#305) [`f8d7b82`](import-js/eslint-import-resolver-typescript@f8d7b82) Thanks [@SukkaW](https://github.com/SukkaW)! - Fix resolve for `node:test`, `node:sea`, and `node:sqlite` without sacrificing installation size - [#288](import-js/eslint-import-resolver-typescript#288) [`a4c6c78`](import-js/eslint-import-resolver-typescript@a4c6c78) Thanks [@SunsetTechuila](https://github.com/SunsetTechuila)! - fix: ignore bun built-in modules
| datasource | package | from | to | | ---------- | --------------------------------- | ----- | ----- | | npm | eslint-import-resolver-typescript | 3.6.1 | 3.6.3 | ## [v3.6.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#363) ##### Patch Changes - [#305](import-js/eslint-import-resolver-typescript#305) [`f8d7b82`](import-js/eslint-import-resolver-typescript@f8d7b82) Thanks [@SukkaW](https://github.com/SukkaW)! - Fix resolve for `node:test`, `node:sea`, and `node:sqlite` without sacrificing installation size - [#288](import-js/eslint-import-resolver-typescript#288) [`a4c6c78`](import-js/eslint-import-resolver-typescript@a4c6c78) Thanks [@SunsetTechuila](https://github.com/SunsetTechuila)! - fix: ignore bun built-in modules
| datasource | package | from | to | | ---------- | --------------------------------- | ----- | ----- | | npm | eslint-import-resolver-typescript | 3.6.1 | 3.6.3 | ## [v3.6.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#363) ##### Patch Changes - [#305](import-js/eslint-import-resolver-typescript#305) [`f8d7b82`](import-js/eslint-import-resolver-typescript@f8d7b82) Thanks [@SukkaW](https://github.com/SukkaW)! - Fix resolve for `node:test`, `node:sea`, and `node:sqlite` without sacrificing installation size - [#288](import-js/eslint-import-resolver-typescript#288) [`a4c6c78`](import-js/eslint-import-resolver-typescript@a4c6c78) Thanks [@SunsetTechuila](https://github.com/SunsetTechuila)! - fix: ignore bun built-in modules
| datasource | package | from | to | | ---------- | --------------------------------- | ----- | ----- | | npm | eslint-import-resolver-typescript | 3.6.1 | 3.6.3 | ## [v3.6.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#363) ##### Patch Changes - [#305](import-js/eslint-import-resolver-typescript#305) [`f8d7b82`](import-js/eslint-import-resolver-typescript@f8d7b82) Thanks [@SukkaW](https://github.com/SukkaW)! - Fix resolve for `node:test`, `node:sea`, and `node:sqlite` without sacrificing installation size - [#288](import-js/eslint-import-resolver-typescript#288) [`a4c6c78`](import-js/eslint-import-resolver-typescript@a4c6c78) Thanks [@SunsetTechuila](https://github.com/SunsetTechuila)! - fix: ignore bun built-in modules
| datasource | package | from | to | | ---------- | --------------------------------- | ----- | ----- | | npm | eslint-import-resolver-typescript | 3.6.1 | 3.6.3 | ## [v3.6.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#363) ##### Patch Changes - [#305](import-js/eslint-import-resolver-typescript#305) [`f8d7b82`](import-js/eslint-import-resolver-typescript@f8d7b82) Thanks [@SukkaW](https://github.com/SukkaW)! - Fix resolve for `node:test`, `node:sea`, and `node:sqlite` without sacrificing installation size - [#288](import-js/eslint-import-resolver-typescript#288) [`a4c6c78`](import-js/eslint-import-resolver-typescript@a4c6c78) Thanks [@SunsetTechuila](https://github.com/SunsetTechuila)! - fix: ignore bun built-in modules
| datasource | package | from | to | | ---------- | --------------------------------- | ----- | ----- | | npm | eslint-import-resolver-typescript | 3.6.1 | 3.6.3 | ## [v3.6.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#363) ##### Patch Changes - [#305](import-js/eslint-import-resolver-typescript#305) [`f8d7b82`](import-js/eslint-import-resolver-typescript@f8d7b82) Thanks [@SukkaW](https://github.com/SukkaW)! - Fix resolve for `node:test`, `node:sea`, and `node:sqlite` without sacrificing installation size - [#288](import-js/eslint-import-resolver-typescript#288) [`a4c6c78`](import-js/eslint-import-resolver-typescript@a4c6c78) Thanks [@SunsetTechuila](https://github.com/SunsetTechuila)! - fix: ignore bun built-in modules
| datasource | package | from | to | | ---------- | --------------------------------- | ----- | ----- | | npm | eslint-import-resolver-typescript | 3.6.1 | 3.6.3 | ## [v3.6.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#363) ##### Patch Changes - [#305](import-js/eslint-import-resolver-typescript#305) [`f8d7b82`](import-js/eslint-import-resolver-typescript@f8d7b82) Thanks [@SukkaW](https://github.com/SukkaW)! - Fix resolve for `node:test`, `node:sea`, and `node:sqlite` without sacrificing installation size - [#288](import-js/eslint-import-resolver-typescript#288) [`a4c6c78`](import-js/eslint-import-resolver-typescript@a4c6c78) Thanks [@SunsetTechuila](https://github.com/SunsetTechuila)! - fix: ignore bun built-in modules
| datasource | package | from | to | | ---------- | --------------------------------- | ----- | ----- | | npm | eslint-import-resolver-typescript | 3.6.1 | 3.6.3 | ## [v3.6.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#363) ##### Patch Changes - [#305](import-js/eslint-import-resolver-typescript#305) [`f8d7b82`](import-js/eslint-import-resolver-typescript@f8d7b82) Thanks [@SukkaW](https://github.com/SukkaW)! - Fix resolve for `node:test`, `node:sea`, and `node:sqlite` without sacrificing installation size - [#288](import-js/eslint-import-resolver-typescript#288) [`a4c6c78`](import-js/eslint-import-resolver-typescript@a4c6c78) Thanks [@SunsetTechuila](https://github.com/SunsetTechuila)! - fix: ignore bun built-in modules
cc @wojtekmaj @SunsetTechuila
Closes #303.
Use
@nolyfill/is-core-module
.node:
prefix only module (node:sea
,node:test
) doesn't exist inmodule.builtinModules
, and I want ESLint to detect typos likenode:slqite
. So we will have to maintain a data set.The differences between
@nolyfill/is-core-module
andis-core-module
:hasown
(which then has a transitive dependencyfunction-bind
)Set#has
instead of thehasown
package