fixed #192, added tests to most rules for importing a naked non-js file.

import-js · Feb 26, 2016 · 594894c · 594894c
1 parent d6e8f84
commit 594894c
Show file tree

Hide file tree

Showing 9 changed files with 19 additions and 0 deletions.
diff --git a/src/rules/namespace.js b/src/rules/namespace.js
@@ -15,6 +15,8 @@ module.exports = function (context) {
   return {
 
     'ImportDeclaration': function (declaration) {
+      if (declaration.specifiers.length === 0) return
+
       const imports = Exports.get(declaration.source.value, context)
       if (imports == null) return null
 

diff --git a/tests/src/rules/default.js b/tests/src/rules/default.js
@@ -6,6 +6,8 @@ var ruleTester = new RuleTester()
 
 ruleTester.run('default', rule, {
   valid: [
+    test({ code: 'import "./malformed.js"' }),
+
     test({code: 'import foo from "./empty-folder";'}),
     test({code: 'import { foo } from "./default-export";'}),
     test({code: 'import foo from "./default-export";'}),

diff --git a/tests/src/rules/export.js b/tests/src/rules/export.js
@@ -7,6 +7,8 @@ var ruleTester = new RuleTester()
 
 ruleTester.run('export', rule, {
   valid: [
+    test({ code: 'import "./malformed.js"' }),
+
     // default
     test({ code: 'var foo = "foo"; export default foo;' }),
     test({ code: 'export var foo = "foo"; export var bar = "bar";'}),

diff --git a/tests/src/rules/named.js b/tests/src/rules/named.js
@@ -11,6 +11,8 @@ function error(name, module) {
 
 ruleTester.run('named', rule, {
   valid: [
+    test({ code: 'import "./malformed.js"' }),
+
     test({code: 'import { foo } from "./bar"'}),
     test({code: 'import { foo } from "./empty-module"'}),
     test({code: 'import bar from "./bar.js"'}),

diff --git a/tests/src/rules/namespace.js b/tests/src/rules/namespace.js
@@ -10,6 +10,8 @@ function error(name, namespace) {
 }
 
 const valid = [
+  test({ code: 'import "./malformed.js"' }),
+
   test({ code: "import * as foo from './empty-folder';"}),
   test({ code: 'import * as names from "./named-exports"; ' +
                'console.log((names.b).c); ' }),

diff --git a/tests/src/rules/no-deprecated.js b/tests/src/rules/no-deprecated.js
@@ -18,6 +18,9 @@ ruleTester.run('no-deprecated', rule, {
   ],
   invalid: [
 
+    // reports on parse errors even without specifiers
+    test({ code: "import './malformed.js'", errors: 1 }),
+
     test({
       code: "import { fn } from './deprecated'",
       errors: ["Deprecated: please use 'x' instead."],

diff --git a/tests/src/rules/no-duplicates.js b/tests/src/rules/no-duplicates.js
@@ -8,6 +8,8 @@ const ruleTester = new RuleTester()
 
 ruleTester.run('no-duplicates', rule, {
   valid: [
+    test({ code: 'import "./malformed.js"' }),
+
     test({ code: "import { x } from './foo'; import { y } from './bar'" }),
 
     // #86: every unresolved module should not show up as 'null' and duplicate

diff --git a/tests/src/rules/no-named-as-default.js b/tests/src/rules/no-named-as-default.js
@@ -6,6 +6,8 @@ const ruleTester = new RuleTester()
 
 ruleTester.run('no-named-as-default', rule, {
   valid: [
+    test({ code: 'import "./malformed.js"' }),
+
     test({code: 'import bar, { foo } from "./bar";'}),
     test({code: 'import bar, { foo } from "./empty-folder";'}),
 

diff --git a/tests/src/rules/no-unresolved.js b/tests/src/rules/no-unresolved.js
@@ -21,6 +21,8 @@ function runResolverTests(resolver) {
 
   ruleTester.run(`no-unresolved (${resolver})`, rule, {
     valid: [
+      test({ code: 'import "./malformed.js"' }),
+
       rest({ code: 'import foo from "./bar";' }),
       rest({ code: "import bar from './bar.js';" }),
       rest({ code: "import {someThing} from './test-module';" }),