Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last update broke webpack sass styles importing #192

Closed
steida opened this issue Feb 26, 2016 · 4 comments
Closed

Last update broke webpack sass styles importing #192

steida opened this issue Feb 26, 2016 · 4 comments
Labels
Milestone

Comments

@steida
Copy link

steida commented Feb 26, 2016

src/browser/app/App.react.js
  1:8  error  Parse errors in imported module './App.scss': Line 3: Unexpected token (3:1)  import/namespace

I am not sure what should I do on my side. This should work: https://github.com/este/este/blob/master/src/browser/app/App.react.js#L1

@benmosher
Copy link
Member

Do you have an import/ignore pattern set up for .scss files? https://github.com/benmosher/eslint-plugin-import/blob/master/README.md#importignore

On Feb 25, 2016, at 19:13, Daniel Steigerwald <notifications@git.luolix.topmailto:notifications@github.com> wrote:

src/browser/app/App.react.js
1:8 error Parse errors in imported module './App.scss': Line 3: Unexpected token (3:1) import/namespace

I am not sure what should I do on my side. This should work: https://github.com/este/este/blob/master/src/browser/app/App.react.js#L1

Reply to this email directly or view it on GitHubhttps://github.com//issues/192.

@benmosher
Copy link
Member

Actually, nvm. I'll fix it on my end. Shouldn't try to parse if there are no specifiers.

@steida
Copy link
Author

steida commented Feb 26, 2016

Awesome! Thank you!

@benmosher
Copy link
Member

Published! 😅 v1.0.2.

FWIW, no-deprecated will still have this issue, but

# .eslintrc.yml
---
settings:
  import/ignore: 
    - \.scss$

would also fix it. That setting instructs the dependency parser to ignore errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants