Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0.0] Missing dependencies fail on npm@2.x.x #604

Closed
moeriki opened this issue Oct 4, 2016 · 1 comment
Closed

[2.0.0] Missing dependencies fail on npm@2.x.x #604

moeriki opened this issue Oct 4, 2016 · 1 comment
Labels
bug

Comments

@moeriki
Copy link

moeriki commented Oct 4, 2016

eslint-plugin-import seems to be missing a dependency on es6-set and object-assign.

This goes unnoticed in npm@3.x.x since they are included with eslint-module-utils, but fails on npm@2.x.x.
@jfmengels jfmengels mentioned this issue Oct 4, 2016
Closed
@jfmengels
Copy link
Collaborator

Thanks for noticing and reporting @moeriki, and sorry for the inconvenience.

I will try to take some time tonight to fix this (probably by using the native Set and Object.assign that are available from Node 4 onwards).

@jfmengels jfmengels added the bug label Oct 4, 2016
jfmengels added a commit that referenced this issue Oct 4, 2016
@jfmengels
#604: Fixed code that relied on removed dependencies
6a83c80
@jfmengels jfmengels mentioned this issue Oct 4, 2016
Merged
jfmengels added a commit that referenced this issue Oct 4, 2016
@jfmengels
(#604): Fixed code that relied on removed dependencies
e14984c
@benmosher benmosher mentioned this issue Oct 6, 2016
Closed
@DJviolin DJviolin mentioned this issue Oct 9, 2016
Closed
This was referenced Apr 15, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moeriki @jfmengels