Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#604: Fixed code that relied on removed dependencies #607

Merged
merged 1 commit into from
Oct 6, 2016

Conversation

jfmengels
Copy link
Collaborator

Fixes #604.
I replaced object-assign and es6-set by native Objct.assign and Set. Since we dropped support for Node < v4, this should not break anything.

@coveralls
Copy link

coveralls commented Oct 4, 2016

Coverage Status

Coverage decreased (-0.001%) to 97.645% when pulling 6a83c80 on remove-useless-deps into 5a6c38d on master.

@jfmengels jfmengels force-pushed the remove-useless-deps branch from 6a83c80 to e14984c Compare October 4, 2016 19:43
@benmosher
Copy link
Member

Agh, thanks. I could've sworn I did a full text search for these before removing.

Also thought CI would catch this. Need to turn on no-extraneous-dependencies! 😅

@coveralls
Copy link

coveralls commented Oct 4, 2016

Coverage Status

Coverage decreased (-0.001%) to 97.645% when pulling e14984c on remove-useless-deps into 5a6c38d on master.

@benmosher benmosher merged commit e14984c into master Oct 6, 2016
@jfmengels jfmengels deleted the remove-useless-deps branch October 6, 2016 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants