Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Namespace] add check for null ExportMap #1235

Merged
merged 1 commit into from
Apr 11, 2019
Merged

[Namespace] add check for null ExportMap #1235

merged 1 commit into from
Apr 11, 2019

Conversation

ljqx
Copy link
Contributor

@ljqx ljqx commented Nov 18, 2018 •
edited
Loading

This PR fixes #1144 .

The issue happens when the dependency has null ExportMap, which happens for ignored or ambiguous modules.

This PR adds a check before doing more verification on the ExportMap.

Test is added following the issue.

@coveralls
Copy link

coveralls commented Nov 18, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 97.865% when pulling 918567d on ljqx:namespace-null-check into 2d21c4c on benmosher:master.

ljharb
ljharb approved these changes Nov 18, 2018
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

@ljharb ljharb merged commit 918567d into import-js:master Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@benmosher benmosher Awaiting requested review from benmosher

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot read property 'namespace' of null
3 participants
@ljqx @coveralls @ljharb