Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize no-cycle rule using strongly connected components #2998

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

optimize no-cycle rule using strongly connected components #2998

wants to merge 7 commits into from
+284 −0

Commits on Apr 8, 2024

  1. [New] [Refactor] no-cycle: use scc algorithm to optimize; add `skip… 

    …ErrorMessagePath` for faster error messages
    @soryy708 @ljharb
    soryy708 authored and ljharb committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    580c241 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. rip out "skip error message path" option 

    it complicates things, and interacts badly with "max depth"
    @soryy708
    soryy708 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    84c8635 View commit details
    Browse the repository at this point in the history

  2. fixup

    @soryy708
    soryy708 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    06d8ec3 View commit details
    Browse the repository at this point in the history

  3. avoid traversing subgraphs outside of my scc

    @soryy708
    soryy708 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    70ea2c6 View commit details
    Browse the repository at this point in the history

  4. ignore type only imports in scc

    @soryy708
    soryy708 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    7e8006e View commit details
    Browse the repository at this point in the history

  5. update fixture

    @soryy708
    soryy708 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    5ebe0d3 View commit details
    Browse the repository at this point in the history

  6. test type-only import cycles

    @soryy708
    soryy708 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    626b91b View commit details
    Browse the repository at this point in the history