Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize no-cycle rule using strongly connected components #2998
base: main
Are you sure you want to change the base?
optimize no-cycle rule using strongly connected components #2998
Changes from all commits
580c241
84c8635
06d8ec3
70ea2c6
7e8006e
5ebe0d3
626b91b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 111 in src/rules/no-cycle.js
src/rules/no-cycle.js#L111
Check warning on line 58 in src/scc.js
src/scc.js#L58
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this line can’t happen, there’s no loop to prevent, so should this check be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact that it shouldn't happen doesn't mean that it can't.
I don't remember why I put it in here, either I actually experienced an endless loop (in which case it can happen), or it protects against regressions on code mutation