Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] Support 'eslint' v9 #3042

Closed
wants to merge 1 commit into from
Closed

Conversation

cosmos-lab
Copy link

Added support for ESLint v9.

Added support for ESLint v9.
Copy link

codecov bot commented Aug 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.88%. Comparing base (32a2b89) to head (268be4e).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (32a2b89) and HEAD (268be4e). Click for more details.

HEAD has 24 uploads less than BASE
Flag BASE (32a2b89) HEAD (268be4e)
42 18
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3042       +/-   ##
===========================================
- Coverage   95.30%   81.88%   -13.43%     
===========================================
  Files          81       92       +11     
  Lines        3411     3970      +559     
  Branches     1195     1303      +108     
===========================================
  Hits         3251     3251               
- Misses        160      719      +559     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tagliala
Copy link

tagliala commented Sep 1, 2024

Hello, this is actually not that simple, please refer to

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nowhere near sufficient to support eslint 9

@ljharb ljharb marked this pull request as draft September 1, 2024 21:32
@ljharb
Copy link
Member

ljharb commented Sep 1, 2024

This is also a duplicate of #2996.

@ljharb ljharb closed this Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants