Filter out default export in an ExportAllDeclaration

[jkimbo]

Fix for #328

@benmosher the fix seems suspiciously simple! Are there any potential problems you can see? Any additional tests that would ensure it's working as expected?

[jfmengels]

I know it was already in the original code (so this is more like a question to @benmosher), but wouldn't it be simpler & less odd (an assignation in a condition? oô), to do const any = remoteExports.length > 0?

I would actually split it up somewhat like this

const namedExports = remoteExports.filter((v, name) => name !== 'default');
const anyNamed = namedExports.length > 0;
namedExports.forEach((v, name) => addNamed(name, node));

[jkimbo]

@jfmengels wouldn't quite work since any is used for the No named exports found in module check below.

This would work though:

const anyNamed = remoteExports.length > 0;
const namedExports = remoteExports.filter((v, name) => name !== 'default');
namedExports.forEach((v, name) => addNamed(name, node));

Happy to change if you think it makes it more readable (I admit I was confused about the assignment in the condition)

[benmosher]

FWIW, remoteExports is more of a Map than an Array, so it has forEach but no filter. It has a size, but this size includes the default name.

I agree that the (any = true) assignment expression is a little laconic, but it gets the job done.

[benmosher]

This is what I ended up with, here: https://github.com/benmosher/eslint-plugin-import/pull/332/files#diff-71778249fbd501cbc801fa0ee1cac9a2R53

default shouldn't count, so it does trigger the no exported names report if you export * from 'foo' where foo has only a default export.

[jkimbo]

That makes sense! I'll close this PR then.

[benmosher]

@jkimbo I think the reason I was thinking it's more complicated is that it's larger than this. I.E. right now named default won't report import SomeDefault from 'foo' if foo has export * from 'bar' and bar has a default export, which I've now learned is wrong.

So it's a larger issue than just the export rule.

I'm going to take a stab at it from inside the export map stuff, let's pause on this for a second.

[jkimbo]

Superseded by #332