Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #328: properly suppress default when looking at * exports. #332

Merged
merged 2 commits into from
May 11, 2016

Conversation

benmosher
Copy link
Member

Supersedes #331, handles export * from '...' suppression of default in all static analysis rules.

cc @jkimbo

@benmosher benmosher added this to the next milestone May 11, 2016
@jkimbo
Copy link

jkimbo commented May 11, 2016

Looks great! Thanks for the quick fix!

@benmosher
Copy link
Member Author

@jkimbo no problem! thanks for catching this. also, thanks for taking a stab at it, your PR was a good jumping-off point. I probably wouldn't have found that line in src/rules/exports.js.

@benmosher benmosher merged commit 1e9c371 into master May 11, 2016
@benmosher benmosher deleted the export-star branch May 11, 2016 13:22
@benmosher benmosher mentioned this pull request May 23, 2016
4 tasks
@benmosher benmosher restored the export-star branch June 1, 2016 10:53
@benmosher benmosher deleted the export-star branch June 1, 2016 10:54
@benmosher benmosher modified the milestones: v1.9.x, next Jun 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants