Check-in all RAL sources #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 29, 2020
Closed
The gen-ral job - ensures that imxrtral.py works - ensures that the Makefile works - ensures that the user hasn't commited RAL changes that aren't described in imxrtral.py The job will generate the RAL over the existing RAL. We check git to see if anything changes. If there are untracked changes, we fail the job.
Default Makefile behavior will compile all of the crates. We're just interested in checking consistency with what's auto-generated, since successful builds will be checked by separate jobs. Create a new 'ci' Makefile target that does everything 'all' does, except checking the Rust code.
mitchmindtree
added a commit
to mitchmindtree/teensy4-rs
that referenced
this pull request
Jul 1, 2020
As of imxrt-rs/imxrt-hal#67 and imxrt-rs/imxrt-hal#68 the `ral` workaround is no longer necessary. As of imxrt-rs/imxrt-hal#69 `Peripherals::steal` is available on the master branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds all RAL sources to the repo. It undoes #15.
This PR is in draft until we identify a way to maintain consistency with
imxrtral.py. Whatever solution we choose will target this branch. We'll review the approach, and merge it into this branch. Then, we'll merge everything intomaster. This should make it easier for us to isolate the interesting changes from the RAL noise.