steal() peripherals; update changelog #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchmindtree
added a commit
to mitchmindtree/teensy4-rs
that referenced
this pull request
Jul 1, 2020
As of imxrt-rs/imxrt-hal#67 and imxrt-rs/imxrt-hal#68 the `ral` workaround is no longer necessary. As of imxrt-rs/imxrt-hal#69 `Peripherals::steal` is available on the master branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds a new function,
steal(), toPeripherals.steal()lets users unsafely acquire all of the peripheral objects. It's unsafe, because the peripherals could be used elsewhere.steal()is used by the RTIC framework to acquire device peripherals. The framework then hands-off the peripherals to the user, who can configure them and wrap them as additional (late) resources.Users can
steal()peripherals in non-RTIC applications. Note thatsteal()always returns the "uninitialized" types, which require additional setup to be useful. In that regard, it's a round-about, unsafe approach towards #20. However, as of this writing, there's no testing to see if re-initializing works for all peripherals.