Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list-diff flag is not work when a recursive path (./...) is given #139

Closed
Ericwww opened this issue Nov 22, 2023 · 2 comments · Fixed by #142
Closed

list-diff flag is not work when a recursive path (./...) is given #139

Ericwww opened this issue Nov 22, 2023 · 2 comments · Fixed by #142

Comments

@Ericwww
Copy link
Contributor

Ericwww commented Nov 22, 2023

Hi, everyone.

I want to integrate goimports-reviser into our CI/CD to ensure that code gating will fail when the import ordering is not as expected.

But I found that list-diff flag is not work when a recursive path (./...) is given.

I am making a PR to fix this bug. But I have one question.

What is the right behavior when `list-diff` flag is given?
Refact code and print file path? or only print file path?

From what I remember, when you run the goimports -l command, it only prints the file path without refactoring the code.

I don't know what behavior is expected here for goimports-reviser.

@Ericwww
Copy link
Contributor Author

Ericwww commented Nov 22, 2023

Here is my PR #140

@incu6us
Copy link
Owner

incu6us commented Nov 25, 2023

Use v3.6.0 tag with the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants