Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug list-diff support dir mode #140

Closed
wants to merge 1 commit into from

Conversation

Ericwww
Copy link
Contributor

@Ericwww Ericwww commented Nov 22, 2023

Hi, everyone.

I want to integrate goimports-reviser into our CI/CD to ensure that code gating will fail when the import ordering is not as expected.

But I found that list-diff flag is not work when a recursive path (./...) is given.

I am making a PR to fix this bug. But I have one question.

What is the right behavior when `list-diff` flag is given?
Refact code and print file path? or only print file path?

From what I remember, when you run the goimports -l command, it only prints the file path without refactoring the code.

I don't know what behavior is expected here for goimports-reviser.

#139

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (85f8a62) 90.38% compared to head (819921b) 90.44%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
+ Coverage   90.38%   90.44%   +0.05%     
==========================================
  Files           9        9              
  Lines         645      649       +4     
==========================================
+ Hits          583      587       +4     
  Misses         43       43              
  Partials       19       19              
Flag Coverage Δ
unittests 90.44% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ericwww Ericwww marked this pull request as ready for review November 24, 2023 14:12
@Ericwww Ericwww changed the title [WIP] fix bug list-diff support dir mode fix bug list-diff support dir mode Nov 24, 2023
@Ericwww
Copy link
Contributor Author

Ericwww commented Nov 24, 2023

@incu6us Hello. If you are free, have a look on this pull request please, thank you. 😄

@incu6us
Copy link
Owner

incu6us commented Nov 24, 2023

@incu6us Hello. If you are free, have a look on this pull request please, thank you. 😄

hi @Ericwww
Checking

@incu6us
Copy link
Owner

incu6us commented Nov 25, 2023

fixed in v3.6.0

@incu6us incu6us closed this Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants