Move to ecstatic v4

[thornjad]

This is a new internal branch version of #520, moved here to make multiple contributions simpler. There are breaking changes but we don't yet know what exactly they are. At the moment, simply upgrading to ecstatic v4 causes http-server to stop serving content, but no errors are thrown.

To contribute to moving to ecstatic v4, make PRs against this branch (use_ecstatic_v4), not master.

Related, ecstatic unpublished their v3.x versions (#521), which is causing fresh installs of http-server to fail. Upgrading to v4 would fix these issues, but it would be better for ecstatic to republish a v3.x version with the security fix (jfhbrook/node-ecstatic#255).

fixes #518, fixes #461, fixes #512, fixes #480

[m2hd1]

🚢 🚢 🚢

[BigBlueHat]

Looks like there may be a replacement ecstatic v3 soon: jfhbrook/node-ecstatic#256

I'd run with that version ASAP (once it's available), but continue this branch to get us on to v4 (as v3's days are clearly numbered...).

[thornjad]

I agree. Thankfully, because we have ^3.0.0 specified in the published version, a 3.3.2 release from jfhbrook/node-ecstatic#256 should work automatically, and should fix the security vulnerability.

[prabhakerb]

do we have any workaround for now?. I have been seeing the following error since today morning hours.

945 verbose stack ecstatic: No matching version found for ecstatic@^2.0.0
3945 verbose stack at pickManifest (/usr/local/lib/node_modules/npm/node_modules/npm-pick-manifest/index.js:65:11)
3945 verbose stack at fetchPackument.then.packument (/usr/local/lib/node_modules/npm/node_modules/pacote/lib/fetchers/registry/manifest.js:52:18)
3946 verbose cwd /Users/bobpr01/ppm-ux
3947 verbose Darwin 18.2.0
3948 verbose argv "/usr/local/bin/node" "/usr/local/bin/npm" "install"
3949 verbose node v10.15.3
3950 verbose npm v6.4.1
3951 error code ETARGET
3952 error notarget No matching version found for ecstatic@^2.0.0
3953 error notarget In most cases you or one of your dependencies are requesting
3953 error notarget a package version that doesn't exist.
3953 error notarget
3953 error notarget It was specified as a dependency of 'http-server'

[brodycj]

do we have any workaround for now?

Install an old version of ecstatic from GitHub?

[thornjad]

@prabhakerb what version of http-server are you trying to use? Your stack trace should be complaining about looking for ecstatic@^3.0.0, not 2.0.0

[prabhakerb]

I am using the http-server 0.10.0 version which installs ecstatic@^2.0.0.

[thornjad]

@prabhakerb once ecstatic publishes a v3 version again, you may want to move to the latest published version of http-server, 0.11.1. Interesting that ecstatic's v2 releases were unpublished as well

[thornjad]

ecstatic has published v3 again, the immediate fire should be out.

Because of the unpublishing problems, as well as the comment that ecstatic will stop being maintained in the future, I've made a fork of ecstatic which we might consider switching to. I'm still getting CI running and haven't published yet, but right now it's just a straight up fork.

[thornjad]

Closing in favor of #693