Fix management of tokens lifetime following RFC9068 #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 19, 2023
enricovianello
requested review from
rmiccoli,
enricovianello,
SteDev2 and
shtimma
|
Kudos, SonarCloud Quality Gate passed! |
enricovianello
requested changes
Jul 21, 2023
.../iam/apps/dashboard-app/components/clients/client/tokensettings/tokensettings.component.html
Outdated
Show resolved
Hide resolved
.../iam/apps/dashboard-app/components/clients/client/tokensettings/tokensettings.component.html
Outdated
Show resolved
Hide resolved
|
Follow the RFC https://datatracker.ietf.org/doc/html/rfc9068 |
|
When AT does not expire, the |
|
@federicaagostini probably a new issue related to "exp" claim could be a good idea |
federicaagostini
force-pushed
the
issue-545-rebased
branch
from
0d5c7c7
to
b972ac9
Compare
federicaagostini
force-pushed
the
issue-545-rebased
branch
from
f13d835
to
5d77475
Compare
when a client request trough API does not explicit one
since the "Token" tab with token-related settings is visible only by Admins. When the lifetimes are not requested during a client update/save, set them to the default values (that are deployment options).
enricovianello
approved these changes
Sep 14, 2023
enricovianello
changed the title
enricovianello
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
enricovianello
added a commit
that referenced
this pull request
Dec 11, 2023
This reverts commit 3749a72.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Access Token and Refresh Token lifetimes are configurable by admins via web interface. #545
The exp claim will always appear into access tokens (following RFC9068). #648