Feature - Refactoring more decorators #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -55,6 +59,28 @@ export class MetadataBuilder { | |||
| })); | |||
| } | |||
|
|
|||
| buildEntrytypeMetadata(target: any, type: EntryType): EntryTypeMetadata[] | undefined { | |||
| @@ -0,0 +1,6 @@ | |||
| export interface DefaultOption { | |||
There was a problem hiding this comment.
default or common? which one is preferable?
There was a problem hiding this comment.
what about only Option, Metadata and Arg instead of DefaultOption, DefaultMetadata and DefaultArg?
There was a problem hiding this comment.
I had some progress in other refactoring and will do this in my upcoming refactor PR
tibawatanabe
approved these changes
Oct 27, 2017
This was referenced Oct 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Query,@Mutation,@Subscriptionand@Schema(now it is missing only@Fielddecorator and the ones related)@UseContainerdecorator to decorator folderschema.type-factoryto be less verbose